NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitdf43fcf

committed

pg_dump: Fix quoting of domain constraint names

The original code was adding double quotes to an already-quotedidentifier, leading to nonsensical results. Remove the quoting call.I introduced the broken code in7eca575 of 9.5 era, so backpatch to9.5.Report and patch by Elvis PranskevichusReviewed by Michael Paquier

1 parente1bd684 commitdf43fcfCopy full SHA for df43fcf

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9611,7 +9611,7 @@ dumpDomain(Archive fout, TypeInfo tyinfo)`
`9611`	`9611`	`appendPQExpBuffer(labelq,"CONSTRAINT %s ",`
`9612`	`9612`	`fmtId(domcheck->dobj.name));`
`9613`	`9613`	`appendPQExpBuffer(labelq,"ON DOMAIN %s",`
`9614`		`-fmtId(qtypname));`
	`9614`	`+qtypname);`
`9615`	`9615`	`dumpComment(fout,labelq->data,`
`9616`	`9616`	`tyinfo->dobj.namespace->dobj.name,`
`9617`	`9617`	`tyinfo->rolname,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdf43fcf

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments