NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitdea95c7

committed

Dump all roles first, then all config settings on roles.

This way, if a role's config setting uses the name of another role,the validity of the dump isn't dependent on the order in which thosetwo roles are dumped.Code by Phil Sorber, comment by me.

1 parent393e828 commitdea95c7Copy full SHA for dea95c7

File tree

1 file changed

-3

lines changed

src/bin/pg_dump
- pg_dumpall.c

1 file changed

-3

lines changed

`‎src/bin/pg_dump/pg_dumpall.c`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -804,11 +804,17 @@ dumpRoles(PGconn *conn)`
`804`	`804`	`buf,"ROLE",rolename);`
`805`	`805`
`806`	`806`	`fprintf(OPF,"%s",buf->data);`
`807`		`-`
`808`		`-if (server_version >=70300)`
`809`		`-dumpUserConfig(conn,rolename);`
`810`	`807`	`}`
`811`	`808`
	`809`	`+/*`
	`810`	`+ * Dump configuration settings for roles after all roles have been dumped.`
	`811`	`+ * We do it this way because config settings for roles could mention the`
	`812`	`+ * names of other roles.`
	`813`	`+ */`
	`814`	`+if (server_version >=70300)`
	`815`	`+for (i=0;i<PQntuples(res);i++)`
	`816`	`+dumpUserConfig(conn,PQgetvalue(res,i,i_rolname));`
	`817`	`+`
`812`	`818`	`PQclear(res);`
`813`	`819`
`814`	`820`	`fprintf(OPF,"\n\n");`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdea95c7

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dumpall.c`

0 commit comments