NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitde6fd1c

committed

Rely on inline functions even if that causes warnings in older compilers.

So far we have worked around the fact that some very old compilers donot support 'inline' functions by only using inline functionsconditionally (or not at all). Since such compilers are very rare bynow, we have decided to rely on inline functions from 9.6 onwards.To avoid breaking these old compilers inline is defined away when notsupported. That'll cause "function x defined but not used" type ofwarnings, but since nobody develops on such compilers anymore that'sok.This change in policy will allow us to more easily employ inlinefunctions.I chose to remove code previously conditional on PG_USE_INLINE as itseemed confusing to have code dependent on a define that's alwaysdefined.Blacklisting of compilers, like inc53f738, now has to be donedifferently. A platform template can define PG_FORCE_DISABLE_INLINE toforce inline to be defined empty.Discussion: 20150701161447.GB30708@awork2.anarazel.de

1 parenta855118 commitde6fd1cCopy full SHA for de6fd1c

File tree

29 files changed

+92

-415

lines changed

configure.in
configure
config
- c-compiler.m4
- test_quiet_include.h
src
- backend
  - lib
    - ilist.c
  - nodes
    - list.c
  - port
    - atomics.c
  - utils
    - adt
      - arrayfuncs.c
    - mmgr
      - mcxt.c
    - sort
      - sortsupport.c
- include
  - access
    - gin_private.h
  - c.h
  - lib
    - ilist.h
  - nodes
    - pg_list.h
  - pg_config.h.in
  - pg_config.h.win32
  - port
    - atomics.h
    - atomics
  - utils
- template
  - aix

29 files changed

+92

-415

lines changed

`‎config/c-compiler.m4‎`

Lines changed: 0 additions & 34 deletions

Original file line number	Diff line number	Diff line change
`@@ -17,40 +17,6 @@ fi])# PGAC_C_SIGNED`
`17`	`17`
`18`	`18`
`19`	`19`
`20`		`-# PGAC_C_INLINE`
`21`		`-# -------------`
`22`		`-# Check if the C compiler understands inline functions without being`
`23`		`-# noisy about unused static inline functions. Some older compilers`
`24`		`-# understand inline functions (as tested by AC_C_INLINE) but warn about`
`25`		`-# them if they aren't used in a translation unit.`
`26`		`-#`
`27`		`-# This test used to just define an inline function, but some compilers`
`28`		`-# (notably clang) got too smart and now warn about unused static`
`29`		`-# inline functions when defined inside a .c file, but not when defined`
`30`		`-# in an included header. Since the latter is what we want to use, test`
`31`		`-# to see if the warning appears when the function is in a header file.`
`32`		`-# Not pretty, but it works.`
`33`		`-#`
`34`		`-# Defines: inline, PG_USE_INLINE`
`35`		`-AC_DEFUN([PGAC_C_INLINE],`
`36`		`-[AC_C_INLINE`
`37`		`-AC_CACHE_CHECK([for quiet inline (no complaint if unreferenced)],pgac_cv_c_inline_quietly,`
`38`		`-[pgac_cv_c_inline_quietly=no`
`39`		`- if test "$ac_cv_c_inline" != no; then`
`40`		`- pgac_c_inline_save_werror=$ac_c_werror_flag`
`41`		`- ac_c_werror_flag=yes`
`42`		`-AC_LINK_IFELSE([AC_LANG_PROGRAM([#include "$srcdir/config/test_quiet_include.h"],[])],`
`43`		`-[pgac_cv_c_inline_quietly=yes])`
`44`		`- ac_c_werror_flag=$pgac_c_inline_save_werror`
`45`		`- fi])`
`46`		`-if test "$pgac_cv_c_inline_quietly" != no; then`
`47`		`-AC_DEFINE_UNQUOTED([PG_USE_INLINE],1,`
`48`		`-[Define to 1 if "static inline" works without unwanted warnings from]`
`49`		`-[compilations where static inline functions are defined but not called.])`
`50`		`-fi`
`51`		`-])# PGAC_C_INLINE`
`52`		`-`
`53`		`-`
`54`	`20`	`# PGAC_C_PRINTF_ARCHETYPE`
`55`	`21`	`# -----------------------`
`56`	`22`	`# Set the format archetype used by gcc to check printf type functions. We`

`‎config/test_quiet_include.h‎`

Lines changed: 0 additions & 18 deletions

This file was deleted.

`‎configure‎`

Lines changed: 0 additions & 38 deletions

Original file line number	Diff line number	Diff line change
`@@ -11006,44 +11006,6 @@ _ACEOF`
`11006`	`11006`	`;;`
`11007`	`11007`	`esac`
`11008`	`11008`
`11009`		`-{$as_echo"$as_me:${as_lineno-$LINENO}: checking for quiet inline (no complaint if unreferenced)">&5`
`11010`		`-$as_echo_n"checking for quiet inline (no complaint if unreferenced)...">&6; }`
`11011`		`-if${pgac_cv_c_inline_quietly+:}false;then:`
`11012`		`-$as_echo_n"(cached)">&6`
`11013`		`-else`
`11014`		`- pgac_cv_c_inline_quietly=no`
`11015`		`-iftest"$ac_cv_c_inline"!= no;then`
`11016`		`- pgac_c_inline_save_werror=$ac_c_werror_flag`
`11017`		`- ac_c_werror_flag=yes`
`11018`		`- cat confdefs.h -<<_ACEOF >conftest.$ac_ext`
`11019`		`-/* end confdefs.h. */`
`11020`		`-#include "$srcdir/config/test_quiet_include.h"`
`11021`		`-int`
`11022`		`-main ()`
`11023`		`-{`
`11024`		`-`
`11025`		`- ;`
`11026`		`- return 0;`
`11027`		`-}`
`11028`		`-_ACEOF`
`11029`		`-if ac_fn_c_try_link"$LINENO";then:`
`11030`		`- pgac_cv_c_inline_quietly=yes`
`11031`		`-fi`
`11032`		`-rm -f core conftest.err conftest.$ac_objext \`
`11033`		`- conftest$ac_exeext conftest.$ac_ext`
`11034`		`- ac_c_werror_flag=$pgac_c_inline_save_werror`
`11035`		`-fi`
`11036`		`-fi`
`11037`		`-{$as_echo"$as_me:${as_lineno-$LINENO}: result:$pgac_cv_c_inline_quietly">&5`
`11038`		`-$as_echo"$pgac_cv_c_inline_quietly">&6; }`
`11039`		`-iftest"$pgac_cv_c_inline_quietly"!= no;then`
`11040`		`-`
`11041`		`-cat>>confdefs.h<<_ACEOF`
`11042`		`-#define PG_USE_INLINE 1`
`11043`		`-_ACEOF`
`11044`		`-`
`11045`		`-fi`
`11046`		`-`
`11047`	`11009`	`{$as_echo"$as_me:${as_lineno-$LINENO}: checking for printf format archetype">&5`
`11048`	`11010`	`$as_echo_n"checking for printf format archetype...">&6; }`
`11049`	`11011`	`if${pgac_cv_printf_archetype+:}false;then:`