NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitdddc91d

committed

Remove broken PGXS code for pg_xlogdump

With the PGXS boilerplate in place, pg_xlogdump currently fails with anominous error message that certain targets cannot be built becausecertain files do not exist. Remove that and instead throw a quick errormessage alerting the user of the actual problem, which should be easierto diagnose that the statu quo.Andres Freund

1 parent7ce569b commitdddc91dCopy full SHA for dddc91d

File tree

1 file changed

-5

lines changed

contrib/pg_xlogdump
- Makefile

1 file changed

-5

lines changed

`‎contrib/pg_xlogdump/Makefile`

Lines changed: 4 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,15 +13,14 @@ RMGRDESCOBJS = $(patsubst %.c,%.o,$(RMGRDESCSOURCES))`
`13`	`13`	`EXTRA_CLEAN =$(RMGRDESCSOURCES) xlogreader.c`
`14`	`14`
`15`	`15`	`ifdefUSE_PGXS`
`16`		`-PG_CONFIG = pg_config`
`17`		`-PGXS :=$(shell$(PG_CONFIG) --pgxs)`
`18`		`-include$(PGXS)`
`19`		`-else`
	`16`	`+$(error "pg_xlogdump cannot be built with PGXS")`
	`17`	`+endif`
	`18`	`+`
`20`	`19`	`subdir = contrib/pg_xlogdump`
`21`	`20`	`top_builddir = ../..`
`22`	`21`	`include$(top_builddir)/src/Makefile.global`
`23`	`22`	`include$(top_srcdir)/contrib/contrib-global.mk`
`24`		`-endif`
	`23`	`+`
`25`	`24`
`26`	`25`	`overrideCPPFLAGS := -DFRONTEND$(CPPFLAGS)`
`27`	`26`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdddc91d

File tree

1 file changed

1 file changed

`‎contrib/pg_xlogdump/Makefile`

0 commit comments