NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitdd077ef

committed

postgres_fdw: Avoid sharing list substructure.

list_concat(list_concat(a, b), c) destructively changes both a and b;to avoid such perils, copy lists of remote_conds before incorporatingthem into larger lists via list_concat().Ashutosh Bapat, per a report from Etsuro Fujita

1 parent902fd1f commitdd077efCopy full SHA for dd077ef

File tree

1 file changed

-8

lines changed

contrib/postgres_fdw
- postgres_fdw.c

1 file changed

-8

lines changed

`‎contrib/postgres_fdw/postgres_fdw.c`

Lines changed: 8 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -3488,30 +3488,30 @@ foreign_join_ok(PlannerInfo root, RelOptInfo joinrel, JoinType jointype,`
`3488`	`3488`	`{`
`3489`	`3489`	`caseJOIN_INNER:`
`3490`	`3490`	`fpinfo->remote_conds=list_concat(fpinfo->remote_conds,`
`3491`		`-fpinfo_i->remote_conds);`
	`3491`	`+list_copy(fpinfo_i->remote_conds));`
`3492`	`3492`	`fpinfo->remote_conds=list_concat(fpinfo->remote_conds,`
`3493`		`-fpinfo_o->remote_conds);`
	`3493`	`+list_copy(fpinfo_o->remote_conds));`
`3494`	`3494`	`break;`
`3495`	`3495`
`3496`	`3496`	`caseJOIN_LEFT:`
`3497`	`3497`	`fpinfo->joinclauses=list_concat(fpinfo->joinclauses,`
`3498`		`-fpinfo_i->remote_conds);`
	`3498`	`+list_copy(fpinfo_i->remote_conds));`
`3499`	`3499`	`fpinfo->remote_conds=list_concat(fpinfo->remote_conds,`
`3500`		`-fpinfo_o->remote_conds);`
	`3500`	`+list_copy(fpinfo_o->remote_conds));`
`3501`	`3501`	`break;`
`3502`	`3502`
`3503`	`3503`	`caseJOIN_RIGHT:`
`3504`	`3504`	`fpinfo->joinclauses=list_concat(fpinfo->joinclauses,`
`3505`		`-fpinfo_o->remote_conds);`
	`3505`	`+list_copy(fpinfo_o->remote_conds));`
`3506`	`3506`	`fpinfo->remote_conds=list_concat(fpinfo->remote_conds,`
`3507`		`-fpinfo_i->remote_conds);`
	`3507`	`+list_copy(fpinfo_i->remote_conds));`
`3508`	`3508`	`break;`
`3509`	`3509`
`3510`	`3510`	`caseJOIN_FULL:`
`3511`	`3511`	`fpinfo->joinclauses=list_concat(fpinfo->joinclauses,`
`3512`		`-fpinfo_i->remote_conds);`
	`3512`	`+list_copy(fpinfo_i->remote_conds));`
`3513`	`3513`	`fpinfo->joinclauses=list_concat(fpinfo->joinclauses,`
`3514`		`-fpinfo_o->remote_conds);`
	`3514`	`+list_copy(fpinfo_o->remote_conds));`
`3515`	`3515`	`break;`
`3516`	`3516`
`3517`	`3517`	`default:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdd077ef

File tree

1 file changed

1 file changed

`‎contrib/postgres_fdw/postgres_fdw.c`

0 commit comments