NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitdcf5e31

committed

PL/Python: Remove procedure cache invalidation

This was added to react to changes in the pg_transform catalog, butbuilding with CLOBBER_CACHE_ALWAYS showed that PL/Python was notprepared for having its procedure cache cleared. Since this is amarginal use case, and we don't do this for other catalogs anyway, wecan postpone this to another day.

1 parent4af6e61 commitdcf5e31Copy full SHA for dcf5e31

File tree

1 file changed

-24

lines changed

src/pl/plpython
- plpy_procedure.c

1 file changed

-24

lines changed

`‎src/pl/plpython/plpy_procedure.c`

Lines changed: 0 additions & 24 deletions

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@`
`29`	`29`	`staticHTAB*PLy_procedure_cache=NULL;`
`30`	`30`
`31`	`31`	`staticPLyProcedure*PLy_procedure_create(HeapTupleprocTup,Oidfn_oid,boolis_trigger);`
`32`		`-staticvoidinvalidate_procedure_caches(Datumarg,intcacheid,uint32hashvalue);`
`33`	`32`	`staticboolPLy_procedure_argument_valid(PLyTypeInfo*arg);`
`34`	`33`	`staticboolPLy_procedure_valid(PLyProcedure*proc,HeapTupleprocTup);`
`35`	`34`	`staticcharPLy_procedure_munge_source(constcharname,constchar*src);`
`@@ -45,29 +44,6 @@ init_procedure_caches(void)`
`45`	`44`	`hash_ctl.entrysize=sizeof(PLyProcedureEntry);`
`46`	`45`	`PLy_procedure_cache=hash_create("PL/Python procedures",32,&hash_ctl,`
`47`	`46`	`HASH_ELEM \|HASH_BLOBS);`
`48`		`-CacheRegisterSyscacheCallback(TRFTYPELANG,`
`49`		`-invalidate_procedure_caches,`
`50`		`- (Datum)0);`
`51`		`-}`
`52`		`-`
`53`		`-staticvoid`
`54`		`-invalidate_procedure_caches(Datumarg,intcacheid,uint32hashvalue)`
`55`		`-{`
`56`		`-HASH_SEQ_STATUSstatus;`
`57`		`-PLyProcedureEntry*hentry;`
`58`		`-`
`59`		`-Assert(PLy_procedure_cache!=NULL);`
`60`		`-`
`61`		`-/* flush all entries */`
`62`		`-hash_seq_init(&status,PLy_procedure_cache);`
`63`		`-`
`64`		`-while ((hentry= (PLyProcedureEntry*)hash_seq_search(&status)))`
`65`		`-{`
`66`		`-if (hash_search(PLy_procedure_cache,`
`67`		`-(void*)&hentry->key,`
`68`		`-HASH_REMOVE,NULL)==NULL)`
`69`		`-elog(ERROR,"hash table corrupted");`
`70`		`-}`
`71`	`47`	`}`
`72`	`48`
`73`	`49`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdcf5e31

File tree

1 file changed

1 file changed

`‎src/pl/plpython/plpy_procedure.c`

0 commit comments