NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitdc1b8ce

committed

Fix plancache's invalidation callback to do the right thing for a SI

reset event, namely invalidate everything. This oversight probablyexplains the rare failures that some buildfarm machines have beenshowing for the plancache regression test.

1 parent1cc97d1 commitdc1b8ceCopy full SHA for dc1b8ce

File tree

1 file changed

-4

lines changed

src/backend/utils/cache
- plancache.c

1 file changed

-4

lines changed

`‎src/backend/utils/cache/plancache.c`

Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@`
`33`	`33`	`* Portions Copyright (c) 1994, Regents of the University of California`
`34`	`34`	`*`
`35`	`35`	`* IDENTIFICATION`
`36`		`- * $PostgreSQL: pgsql/src/backend/utils/cache/plancache.c,v 1.4 2007/03/23 19:53:51 tgl Exp $`
	`36`	`+ * $PostgreSQL: pgsql/src/backend/utils/cache/plancache.c,v 1.5 2007/03/26 00:36:19 tgl Exp $`
`37`	`37`	`*`
`38`	`38`	`*-------------------------------------------------------------------------`
`39`	`39`	`*/`
`@@ -812,6 +812,9 @@ PlanCacheComputeResultDesc(List *stmt_list)`
`812`	`812`	`/*`
`813`	`813`	`* PlanCacheCallback`
`814`	`814`	`*Relcache inval callback function`
	`815`	`+ *`
	`816`	`+ * Invalidate all plans mentioning the given rel, or all plans mentioning`
	`817`	`+ * any rel at all if relid == InvalidOid.`
`815`	`818`	`*/`
`816`	`819`	`staticvoid`
`817`	`820`	`PlanCacheCallback(Datumarg,Oidrelid)`
`@@ -843,7 +846,7 @@ PlanCacheCallback(Datum arg, Oid relid)`
`843`	`846`
`844`	`847`	`if (rte->rtekind!=RTE_RELATION)`
`845`	`848`	`continue;`
`846`		`-if (relid==rte->relid)`
	`849`	`+if (relid==rte->relid\|\|relid==InvalidOid)`
`847`	`850`	`{`
`848`	`851`	`/* Invalidate the plan! */`
`849`	`852`	`plan->dead= true;`
`@@ -883,10 +886,11 @@ PlanCacheCallback(Datum arg, Oid relid)`
`883`	`886`	`staticvoid`
`884`	`887`	`InvalRelid(Oidrelid,LOCKMODElockmode,InvalRelidContext*context)`
`885`	`888`	`{`
`886`		`-if (relid==context->inval_relid)`
	`889`	`+if (relid==context->inval_relid\|\|context->inval_relid==InvalidOid)`
`887`	`890`	`context->plan->dead= true;`
`888`	`891`	`}`
`889`	`892`
	`893`	`+`
`890`	`894`	`/*`
`891`	`895`	`* HaveCachedPlans`
`892`	`896`	`*Check if the plancache has stored any plans at all.`
`@@ -896,4 +900,3 @@ HaveCachedPlans(void)`
`896`	`900`	`{`
`897`	`901`	`return (cached_plans_list!=NIL);`
`898`	`902`	`}`
`899`		`-`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdc1b8ce

File tree

1 file changed

1 file changed

`‎src/backend/utils/cache/plancache.c`

0 commit comments