NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitdb4ef73

committed

Don't crash when pg_xlog is empty and pg_basebackup -x is used

The backup will not work (without a logarchive, and that's the wholepoint of -x) in this case, this patch just changes it to throw anerror instead of crashing when this happens.Noticed and diagnosed by TAKATSUKA Haruka

1 parentfcf9eca commitdb4ef73Copy full SHA for db4ef73

File tree

1 file changed

-0

lines changed

src/backend/replication
- basebackup.c

1 file changed

-0

lines changed

`‎src/backend/replication/basebackup.c`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -303,6 +303,14 @@ perform_base_backup(basebackup_options opt, DIR tblspcdir)`
`303`	`303`	`}`
`304`	`304`	`qsort(walFiles,nWalFiles,sizeof(char*),compareWalFileNames);`
`305`	`305`
	`306`	`+/*`
	`307`	`+ * There must be at least one xlog file in the pg_xlog directory,`
	`308`	`+ * since we are doing backup-including-xlog.`
	`309`	`+ */`
	`310`	`+if (nWalFiles<1)`
	`311`	`+ereport(ERROR,`
	`312`	`+(errmsg("could not find any WAL files")));`
	`313`	`+`
`306`	`314`	`/*`
`307`	`315`	`* Sanity check: the first and last segment should cover startptr and`
`308`	`316`	`* endptr, with no gaps in between.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdb4ef73

File tree

1 file changed

1 file changed

`‎src/backend/replication/basebackup.c`

0 commit comments