NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitdb4a5cf

committed

Use "g" not "f" format in ecpg's PGTYPESnumeric_from_double().

The previous coding could overrun the provided buffer size for a very largeinput, or lose precision for a very small input. Adopt the methodologythat's been in use in the equivalent backend code for a long time.Per private report from Bas van Schaik. Back-patch to all supportedbranches.

1 parent2287b87 commitdb4a5cfCopy full SHA for db4a5cf

File tree

1 file changed

-2

lines changed

src/interfaces/ecpg/pgtypeslib
- numeric.c

1 file changed

-2

lines changed

`‎src/interfaces/ecpg/pgtypeslib/numeric.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@`
`2`	`2`
`3`	`3`	`#include"postgres_fe.h"`
`4`	`4`	`#include<ctype.h>`
	`5`	`+#include<float.h>`
`5`	`6`	`#include<limits.h>`
`6`	`7`
`7`	`8`	`#include"extern.h"`
`@@ -1497,11 +1498,11 @@ PGTYPESnumeric_copy(numeric src, numeric dst)`
`1497`	`1498`	`int`
`1498`	`1499`	`PGTYPESnumeric_from_double(doubled,numeric*dst)`
`1499`	`1500`	`{`
`1500`		`-charbuffer[100];`
	`1501`	`+charbuffer[DBL_DIG+100];`
`1501`	`1502`	`numeric*tmp;`
`1502`	`1503`	`inti;`
`1503`	`1504`
`1504`		`-if (sprintf(buffer,"%f",d)==0)`
	`1505`	`+if (sprintf(buffer,"%.*g",DBL_DIG,d)<=0)`
`1505`	`1506`	`return-1;`
`1506`	`1507`
`1507`	`1508`	`if ((tmp=PGTYPESnumeric_from_asc(buffer,NULL))==NULL)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitdb4a5cf

File tree

1 file changed

1 file changed

`‎src/interfaces/ecpg/pgtypeslib/numeric.c`

0 commit comments