NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitda9659f

committed

Fix possible sorting error when aborting use of abbreviated keys.

Due to an error in the abbreviated key abort logic, the most recentlyprocessed SortTuple could be incorrectly marked NULL, resulting in anincorrect final sort order.In the worst case, this could result in a corrupt btree index, whichwould need to be rebuild using REINDEX. However, abbrevation doesn'tabort very often, not all data types use it, and only one tuple wouldend up in the wrong place, so the practical impact of this mistake maybe somewhat limited.Report and patch by Peter Geoghegan.

1 parentac3aac3 commitda9659fCopy full SHA for da9659f

File tree

1 file changed

-3

lines changed

src/backend/utils/sort
- tuplesort.c

1 file changed

-3

lines changed

`‎src/backend/utils/sort/tuplesort.c`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1314,7 +1314,7 @@ tuplesort_putindextuplevalues(Tuplesortstate *state, Relation rel,`
`1314`	`1314`	`mtup->datum1=index_getattr(tuple,`
`1315`	`1315`	`1,`
`1316`	`1316`	`RelationGetDescr(state->indexRel),`
`1317`		`-&stup.isnull1);`
	`1317`	`+&mtup->isnull1);`
`1318`	`1318`	`}`
`1319`	`1319`	`}`
`1320`	`1320`
`@@ -3440,7 +3440,7 @@ copytup_cluster(Tuplesortstate state, SortTuple stup, void *tup)`
`3440`	`3440`	`mtup->datum1=heap_getattr(tuple,`
`3441`	`3441`	`state->indexInfo->ii_KeyAttrNumbers[0],`
`3442`	`3442`	`state->tupDesc,`
`3443`		`-&stup->isnull1);`
	`3443`	`+&mtup->isnull1);`
`3444`	`3444`	`}`
`3445`	`3445`	`}`
`3446`	`3446`	`}`
`@@ -3744,7 +3744,7 @@ copytup_index(Tuplesortstate state, SortTuple stup, void *tup)`
`3744`	`3744`	`mtup->datum1=index_getattr(tuple,`
`3745`	`3745`	`1,`
`3746`	`3746`	`RelationGetDescr(state->indexRel),`
`3747`		`-&stup->isnull1);`
	`3747`	`+&mtup->isnull1);`
`3748`	`3748`	`}`
`3749`	`3749`	`}`
`3750`	`3750`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitda9659f

File tree

1 file changed

1 file changed

`‎src/backend/utils/sort/tuplesort.c`

0 commit comments