NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitd9e7495

committed

start_postmaster() registered stop_postmaster_atexit as an atexit(3)callback each time through, although the obvious intention was to doso only once per program run. The extra registrations were harmless,so long as we didn't exceed ATEXIT_MAX, but still it's a bug.Artur Zakirov, with bikeshedding by Kyotaro Horiguchi and meDiscussion: <d279e817-02b5-caa6-215f-cfb05dce109a@postgrespro.ru>

1 parentde8c92e commitd9e7495Copy full SHA for d9e7495

File tree

1 file changed

-1

lines changed

src/bin/pg_upgrade
- server.c

1 file changed

-1

lines changed

`‎src/bin/pg_upgrade/server.c‎`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -174,10 +174,11 @@ start_postmaster(ClusterInfo *cluster, bool throw_error)`
`174`	`174`	`{`
`175`	`175`	`charcmd[MAXPGPATH*4+1000];`
`176`	`176`	`PGconn*conn;`
`177`		`-boolexit_hook_registered= false;`
`178`	`177`	`boolpg_ctl_return= false;`
`179`	`178`	`charsocket_string[MAXPGPATH+200];`
`180`	`179`
	`180`	`+staticboolexit_hook_registered= false;`
	`181`	`+`
`181`	`182`	`if (!exit_hook_registered)`
`182`	`183`	`{`
`183`	`184`	`atexit(stop_postmaster_atexit);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd9e7495

File tree

1 file changed

1 file changed

`‎src/bin/pg_upgrade/server.c‎`

0 commit comments