Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitd9b31e4

Browse files
committed
Fix some more bugs in contrib/xml2's xslt_process().
It failed to check for error return from xsltApplyStylesheet(), as reportedby Peter Gagarinov. (So far as I can tell, libxslt provides no convenientway to get a useful error message in failure cases. There might be someinconvenient way, but considering that this code is deprecated it's hard toget enthusiastic about putting lots of work into it. So I just made it say"failed to apply stylesheet", in line with the existing error checks.)While looking at the code I also noticed that the string returned byxsltSaveResultToString was never freed, resulting in a session-lifespanmemory leak.Back-patch to all supported versions.
1 parentd73b7f9 commitd9b31e4

File tree

1 file changed

+13
-1
lines changed

1 file changed

+13
-1
lines changed

‎contrib/xml2/xslt_proc.c

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ xslt_process(PG_FUNCTION_ARGS)
5454

5555
text*doct=PG_GETARG_TEXT_P(0);
5656
text*ssheet=PG_GETARG_TEXT_P(1);
57+
text*result;
5758
text*paramstr;
5859
constchar**params;
5960
PgXmlErrorContext*xmlerrcxt;
@@ -112,6 +113,11 @@ xslt_process(PG_FUNCTION_ARGS)
112113
"failed to parse stylesheet");
113114

114115
restree=xsltApplyStylesheet(stylesheet,doctree,params);
116+
117+
if (restree==NULL)
118+
xml_ereport(xmlerrcxt,ERROR,ERRCODE_EXTERNAL_ROUTINE_EXCEPTION,
119+
"failed to apply stylesheet");
120+
115121
resstat=xsltSaveResultToString(&resstr,&reslen,restree,stylesheet);
116122
}
117123
PG_CATCH();
@@ -137,10 +143,16 @@ xslt_process(PG_FUNCTION_ARGS)
137143

138144
pg_xml_done(xmlerrcxt, false);
139145

146+
/* XXX this is pretty dubious, really ought to throw error instead */
140147
if (resstat<0)
141148
PG_RETURN_NULL();
142149

143-
PG_RETURN_TEXT_P(cstring_to_text_with_len((char*)resstr,reslen));
150+
result=cstring_to_text_with_len((char*)resstr,reslen);
151+
152+
if (resstr)
153+
xmlFree(resstr);
154+
155+
PG_RETURN_TEXT_P(result);
144156
#else/* !USE_LIBXSLT */
145157

146158
ereport(ERROR,

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp