NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitd934a05

committed

Fix uninitialized-variable warning.

In passing, add an Assert defending the presumption that bytes_leftis positive to start with. (I'm not exactly convinced that using anunsigned type was such a bright thing here, but let's at least dothis much.)

1 parentaedccb1 commitd934a05Copy full SHA for d934a05

File tree

1 file changed

-2

lines changed

src/backend/utils/misc
- guc.c

1 file changed

-2

lines changed

`‎src/backend/utils/misc/guc.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8741,9 +8741,10 @@ SerializeGUCState(Size maxsize, char *start_address)`
`8741`	`8741`	`Sizeactual_size;`
`8742`	`8742`	`Sizebytes_left;`
`8743`	`8743`	`inti;`
`8744`		`-inti_role;`
	`8744`	`+inti_role=-1;`
`8745`	`8745`
`8746`	`8746`	`/* Reserve space for saving the actual size of the guc state */`
	`8747`	`+Assert(maxsize>sizeof(actual_size));`
`8747`	`8748`	`curptr=start_address+sizeof(actual_size);`
`8748`	`8749`	`bytes_left=maxsize-sizeof(actual_size);`
`8749`	`8750`
`@@ -8759,7 +8760,8 @@ SerializeGUCState(Size maxsize, char *start_address)`
`8759`	`8760`	`else`
`8760`	`8761`	`serialize_variable(&curptr,&bytes_left,guc_variables[i]);`
`8761`	`8762`	`}`
`8762`		`-serialize_variable(&curptr,&bytes_left,guc_variables[i_role]);`
	`8763`	`+if (i_role >=0)`
	`8764`	`+serialize_variable(&curptr,&bytes_left,guc_variables[i_role]);`
`8763`	`8765`
`8764`	`8766`	`/* Store actual size without assuming alignment of start_address. */`
`8765`	`8767`	`actual_size=maxsize-bytes_left-sizeof(actual_size);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd934a05

File tree

1 file changed

1 file changed

`‎src/backend/utils/misc/guc.c`

0 commit comments