Commitd82a1d5

committed

This is the patch replace offnum++ by OffsetNumberNext, to be

consistent. OffsetNumberNext() has some casting that makes it useful.Fujii Masao

1 parenta61b246 commitd82a1d5Copy full SHA for d82a1d5

File tree

-7

lines changed

-7

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/access/heap/pruneheap.c,v 1.11 2008/05/12 16:06:09 alvherre Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/access/heap/pruneheap.c,v 1.12 2008/05/13 15:44:08 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -792,7 +792,7 @@ heap_get_root_tuples(Page page, OffsetNumber *root_offsets)`
`792`	`792`	`MemSet(root_offsets,0,MaxHeapTuplesPerPage*sizeof(OffsetNumber));`
`793`	`793`
`794`	`794`	`maxoff=PageGetMaxOffsetNumber(page);`
`795`		`-for (offnum=FirstOffsetNumber;offnum <=maxoff;offnum++)`
	`795`	`+for (offnum=FirstOffsetNumber;offnum <=maxoff;offnum=OffsetNumberNext(offnum))`
`796`	`796`	`{`
`797`	`797`	`ItemIdlp=PageGetItemId(page,offnum);`
`798`	`798`	`HeapTupleHeaderhtup;`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`*`
`22`	`22`	`*`
`23`	`23`	`* IDENTIFICATION`
`24`		`- * $PostgreSQL: pgsql/src/backend/executor/nodeBitmapHeapscan.c,v 1.27 2008/05/12 00:00:49 alvherre Exp $`
	`24`	`+ * $PostgreSQL: pgsql/src/backend/executor/nodeBitmapHeapscan.c,v 1.28 2008/05/13 15:44:08 momjian Exp $`
`25`	`25`	`*`
`26`	`26`	`*-------------------------------------------------------------------------`
`27`	`27`	`*/`
`@@ -302,7 +302,7 @@ bitgetpage(HeapScanDesc scan, TBMIterateResult *tbmres)`
`302`	`302`	`OffsetNumbermaxoff=PageGetMaxOffsetNumber(dp);`
`303`	`303`	`OffsetNumberoffnum;`
`304`	`304`
`305`		`-for (offnum=FirstOffsetNumber;offnum <=maxoff;offnum++)`
	`305`	`+for (offnum=FirstOffsetNumber;offnum <=maxoff;offnum=OffsetNumberNext(offnum))`
`306`	`306`	`{`
`307`	`307`	`ItemIdlp;`
`308`	`308`	`HeapTupleDataloctup;`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/storage/page/bufpage.c,v 1.78 2008/02/10 20:39:08tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/storage/page/bufpage.c,v 1.79 2008/05/13 15:44:08momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -533,7 +533,7 @@ PageGetHeapFreeSpace(Page page)`
`533`	`533`	`* Since this is just a hint, we must confirm that there is`
`534`	`534`	`* indeed a free line pointer`
`535`	`535`	`*/`
`536`		`-for (offnum=FirstOffsetNumber;offnum <=nline;offnum++)`
	`536`	`+for (offnum=FirstOffsetNumber;offnum <=nline;offnum=OffsetNumberNext(offnum))`
`537`	`537`	`{`
`538`	`538`	`ItemIdlp=PageGetItemId(page,offnum);`
`539`	`539`
`@@ -736,7 +736,7 @@ PageIndexMultiDelete(Page page, OffsetNumber *itemnos, int nitems)`
`736`	`736`	`totallen=0;`
`737`	`737`	`nused=0;`
`738`	`738`	`nextitm=0;`
`739`		`-for (offnum=1;offnum <=nline;offnum++)`
	`739`	`+for (offnum=FirstOffsetNumber;offnum <=nline;offnum=OffsetNumberNext(offnum))`
`740`	`740`	`{`
`741`	`741`	`lp=PageGetItemId(page,offnum);`
`742`	`742`	`Assert(ItemIdHasStorage(lp));`

Comments

(0)