Commitd7fd22a

committed

Fix memory leaks in pg_rewind. Several PQclear() calls were missing.

Originally reported by Vladimir Borodin in the pg_rewind github project,patch by Michael Paquier.

1 parent820d1ce commitd7fd22aCopy full SHA for d7fd22a

File tree

-0

lines changed

-0

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -350,6 +350,8 @@ libpqGetFile(const char filename, size_t filesize)`
`350`	`350`	`memcpy(result,PQgetvalue(res,0,0),len);`
`351`	`351`	`result[len]='\0';`
`352`	`352`
	`353`	`+PQclear(res);`
	`354`	`+`
`353`	`355`	`pg_log(PG_DEBUG,"fetched file \"%s\", length %d\n",filename,len);`
`354`	`356`
`355`	`357`	`if (filesize)`
`@@ -410,13 +412,15 @@ libpq_executeFileMap(filemap_t *map)`
`410`	`412`	`if (PQresultStatus(res)!=PGRES_COMMAND_OK)`
`411`	`413`	`pg_fatal("could not create temporary table: %s",`
`412`	`414`	`PQresultErrorMessage(res));`
	`415`	`+PQclear(res);`
`413`	`416`
`414`	`417`	`sql="COPY fetchchunks FROM STDIN";`
`415`	`418`	`res=PQexec(conn,sql);`
`416`	`419`
`417`	`420`	`if (PQresultStatus(res)!=PGRES_COPY_IN)`
`418`	`421`	`pg_fatal("could not send file list: %s",`
`419`	`422`	`PQresultErrorMessage(res));`
	`423`	`+PQclear(res);`
`420`	`424`
`421`	`425`	`for (i=0;i<map->narray;i++)`
`422`	`426`	`{`
`@@ -464,6 +468,7 @@ libpq_executeFileMap(filemap_t *map)`
`464`	`468`	`if (PQresultStatus(res)!=PGRES_COMMAND_OK)`
`465`	`469`	`pg_fatal("unexpected result while sending file list: %s",`
`466`	`470`	`PQresultErrorMessage(res));`
	`471`	`+PQclear(res);`
`467`	`472`	`}`
`468`	`473`
`469`	`474`	`/*`

Comments

(0)