Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitd7b2cd9

Browse files
committed
Fix pg_config.h make rule
According to the Autoconf documentation, there should be a make rulepg_config.h: stamp-hso that with the right setup around this, a change in pg_config.h.inwill trigger a rebuild of everything that depends on pg_config.h. Butthis doesn't always work, sometimes you need to run make twice to geteverything up to date after a change of pg_config.h.in.The fix is to write the rule aspg_config.h: stamp-h ;instead (with an empty command instead of no command). This is whatAutomake-generated makefiles effectively do, so it seems safe to be onthis side.It's not actually clear why this is (apparently) more correct. It'sbeen posted to<http://lists.gnu.org/archive/html/help-make/2012-04/msg00058.html>without response so far.
1 parent916d589 commitd7b2cd9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

‎src/Makefile.global.in

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -536,18 +536,18 @@ $(top_builddir)/src/Makefile.global: $(top_srcdir)/src/Makefile.global.in $(top_
536536
# unnecessarily. Therefore we make config.status update a timestamp file
537537
# stamp-h every time it runs, so that we don't trigger this rule every time.
538538
# (We do trigger the null rule for stamp-h to pg_config.h every time; so it's
539-
# important for that rule to benull!)
539+
# important for that rule to beempty!)
540540
#
541541
# Of course you need to turn on dependency tracking to get any
542542
# dependencies on pg_config.h.
543-
$(top_builddir)/src/include/pg_config.h:$(top_builddir)/src/include/stamp-h
543+
$(top_builddir)/src/include/pg_config.h:$(top_builddir)/src/include/stamp-h ;
544544

545545
$(top_builddir)/src/include/stamp-h:$(top_srcdir)/src/include/pg_config.h.in$(top_builddir)/config.status
546546
cd$(top_builddir)&& ./config.status src/include/pg_config.h
547547

548548
# Also remake ecpg_config.h from ecpg_config.h.in if the latter changed, same
549549
# logic as above.
550-
$(top_builddir)/src/interfaces/ecpg/include/ecpg_config.h:$(top_builddir)/src/interfaces/ecpg/include/stamp-h
550+
$(top_builddir)/src/interfaces/ecpg/include/ecpg_config.h:$(top_builddir)/src/interfaces/ecpg/include/stamp-h ;
551551

552552
$(top_builddir)/src/interfaces/ecpg/include/stamp-h:$(top_builddir)/src/interfaces/ecpg/include/ecpg_config.h.in$(top_builddir)/config.status
553553
cd$(top_builddir)&& ./config.status src/interfaces/ecpg/include/ecpg_config.h

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp