NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitd665162

committed

Don't try to use a constraint name as domain name

The bug that caused this to be discovered is that the code was trying todereference a NULL or ill-defined pointer, as reported by Michael Mueller;but what it was doing was wrong anyway, per Heikki.This patch is Heikki's suggested fix.

1 parent9f08452 commitd665162Copy full SHA for d665162

File tree

1 file changed

-2

lines changed

src/backend/commands
- typecmds.c

1 file changed

-2

lines changed

`‎src/backend/commands/typecmds.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2096,13 +2096,13 @@ AlterDomainValidateConstraint(List names, char constrName)`
`2096`	`2096`	`ereport(ERROR,`
`2097`	`2097`	`(errcode(ERRCODE_UNDEFINED_OBJECT),`
`2098`	`2098`	`errmsg("constraint \"%s\" of domain \"%s\" does not exist",`
`2099`		`-constrName,NameStr(con->conname))));`
	`2099`	`+constrName,TypeNameToString(typename))));`
`2100`	`2100`
`2101`	`2101`	`if (con->contype!=CONSTRAINT_CHECK)`
`2102`	`2102`	`ereport(ERROR,`
`2103`	`2103`	`(errcode(ERRCODE_WRONG_OBJECT_TYPE),`
`2104`	`2104`	`errmsg("constraint \"%s\" of domain \"%s\" is not a check constraint",`
`2105`		`-constrName,NameStr(con->conname))));`
	`2105`	`+constrName,TypeNameToString(typename))));`
`2106`	`2106`
`2107`	`2107`	`val=SysCacheGetAttr(CONSTROID,tuple,`
`2108`	`2108`	`Anum_pg_constraint_conbin,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd665162

File tree

1 file changed

1 file changed

`‎src/backend/commands/typecmds.c`

0 commit comments