NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitd5f4df7

committed

Fix bug in the test of file descriptor of current WAL file in pg_receivexlog.

In pg_receivexlog, in order to check whether the current WAL file isbeing opened or not, its file descriptor has to be checked against -1as an invalid value. But, oops, 7900e94 added the incorrect testchecking the descriptor against 1. This commit fixes that bug.Back-patch to 9.4 where the bug was added.Spotted by Magnus Hagander

1 parentf66c20b commitd5f4df7Copy full SHA for d5f4df7

File tree

1 file changed

-1

lines changed

src/bin/pg_basebackup
- receivelog.c

1 file changed

-1

lines changed

`‎src/bin/pg_basebackup/receivelog.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1021,7 +1021,7 @@ ProcessKeepaliveMsg(PGconn conn, char copybuf, int len,`
`1021`	`1021`	`if (replyRequested&&still_sending)`
`1022`	`1022`	`{`
`1023`	`1023`	`if (reportFlushPosition&&lastFlushPosition<blockpos&&`
`1024`		`-walfile!=1)`
	`1024`	`+walfile!=-1)`
`1025`	`1025`	`{`
`1026`	`1026`	`/*`
`1027`	`1027`	`* If a valid flush location needs to be reported,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd5f4df7

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/receivelog.c‎`

0 commit comments