Commitd4b49b4

committed

Avoid generating excess (and illegal) parentheses around an aliased JOIN

in prettyprint mode. Andreas Pflug

1 parentcda3e58 commitd4b49b4Copy full SHA for d4b49b4

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`	`*back to source text`
`4`	`4`	`*`
`5`	`5`	`* IDENTIFICATION`
`6`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.186 2004/12/11 23:26:45 tgl Exp $`
	`6`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/ruleutils.c,v 1.187 2004/12/13 00:33:06 tgl Exp $`
`7`	`7`	`*`
`8`	`8`	`* This software is copyrighted by Jan Wieck - Hamburg.`
`9`	`9`	`*`
`@@ -3903,7 +3903,8 @@ get_from_clause_item(Node jtnode, Query query, deparse_context *context)`
`3903`	`3903`	`boolneed_paren_on_right;`
`3904`	`3904`
`3905`	`3905`	`need_paren_on_right=PRETTY_PAREN(context)&&`
`3906`		`-!IsA(j->rarg,RangeTblRef);`
	`3906`	`+!IsA(j->rarg,RangeTblRef)&&`
	`3907`	`+!(IsA(j->rarg,JoinExpr)&& ((JoinExpr*)j->rarg)->alias!=NULL);`
`3907`	`3908`
`3908`	`3909`	`if (!PRETTY_PAREN(context)\|\|j->alias!=NULL)`
`3909`	`3910`	`appendStringInfoChar(buf,'(');`

Comments

(0)