NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitd461d05

committed

For testing purposes, reinsert a timeout in pgstat.c's wait call.

Test results from buildfarm members mastodon/narwhal (Windows Server 2003)make it look like that platform just plain loses FD_READ eventsoccasionally, and the only reason our previous coding seemed to work wasthat it timed out every couple of seconds and retried the whole operation.Try to verify this by reinserting a finite timeout into the pgstat loop.This isn't meant to be a permanent patch either, just to confirm ordisprove a theory.

1 parentf1ca515 commitd461d05Copy full SHA for d461d05

File tree

1 file changed

-2

lines changed

src/backend/postmaster
- pgstat.c

1 file changed

-2

lines changed

`‎src/backend/postmaster/pgstat.c`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3241,10 +3241,11 @@ PgstatCollectorMain(int argc, char *argv[])`
`3241`	`3241`	`elog(LOG,"pgstat: waiting");`
`3242`	`3242`
`3243`	`3243`	`/* Sleep until there's something to do */`
	`3244`	`+/* XXX should not need a timeout here */`
`3244`	`3245`	`wr=WaitLatchOrSocket(&pgStatLatch,`
`3245`		`-WL_LATCH_SET \|WL_POSTMASTER_DEATH \|WL_SOCKET_READABLE,`
	`3246`	`+WL_LATCH_SET \|WL_POSTMASTER_DEATH \|WL_SOCKET_READABLE \|WL_TIMEOUT,`
`3246`	`3247`	`pgStatSock,`
`3247`		`--1L);`
	`3248`	`+2000L);`
`3248`	`3249`
`3249`	`3250`	`elog(LOG,"pgstat: wait result 0x%x",wr);`
`3250`	`3251`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd461d05

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/pgstat.c`

0 commit comments