NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitd431848

committed

libpq: Fix minor memory leaks

When using connection info arrays with a conninfo string in the dbnameslot, some memory would be leaked if an error occurred whileprocessing the following array slots.found by Coverity

1 parent598bb8c commitd431848Copy full SHA for d431848

File tree

1 file changed

-0

lines changed

src/interfaces/libpq
- fe-connect.c

1 file changed

-0

lines changed

`‎src/interfaces/libpq/fe-connect.c‎`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4303,6 +4303,7 @@ conninfo_array_parse(const char const keywords, const char const values,`
`4303`	`4303`	`{`
`4304`	`4304`	`printfPQExpBuffer(errorMessage,`
`4305`	`4305`	`libpq_gettext("out of memory\n"));`
	`4306`	`+PQconninfoFree(str_options);`
`4306`	`4307`	`returnNULL;`
`4307`	`4308`	`}`
`4308`	`4309`	`memcpy(options,PQconninfoOptions,sizeof(PQconninfoOptions));`
`@@ -4330,6 +4331,7 @@ conninfo_array_parse(const char const keywords, const char const values,`
`4330`	`4331`	`libpq_gettext("invalid connection option \"%s\"\n"),`
`4331`	`4332`	`pname);`
`4332`	`4333`	`PQconninfoFree(options);`
	`4334`	`+PQconninfoFree(str_options);`
`4333`	`4335`	`returnNULL;`
`4334`	`4336`	`}`
`4335`	`4337`
`@@ -4374,6 +4376,7 @@ conninfo_array_parse(const char const keywords, const char const values,`
`4374`	`4376`	`printfPQExpBuffer(errorMessage,`
`4375`	`4377`	`libpq_gettext("out of memory\n"));`
`4376`	`4378`	`PQconninfoFree(options);`
	`4379`	`+PQconninfoFree(str_options);`
`4377`	`4380`	`returnNULL;`
`4378`	`4381`	`}`
`4379`	`4382`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd431848

File tree

1 file changed

1 file changed

`‎src/interfaces/libpq/fe-connect.c‎`

0 commit comments