Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitd287c9e

Browse files
committed
Restore previous ordering of BUFFER_FLUSH_START probe. I had wanted to
make it include the time for the possible smgropen() call, but thatresults in a null pointer dereference :-(.An alternative solution would be to fetch the buffer tag instead oflooking at *reln, but I'll just put it back as it was for the moment.BTW, this indicates that DTrace probes evaluate their arguments evenwhen nominally inactive. What was that about "zero cost", again?
1 parent2dd9af8 commitd287c9e

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

‎src/backend/storage/buffer/bufmgr.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.246 2009/03/11 23:19:25 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.247 2009/03/13 17:46:21 tgl Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -1861,14 +1861,14 @@ FlushBuffer(volatile BufferDesc *buf, SMgrRelation reln)
18611861
errcontext.previous=error_context_stack;
18621862
error_context_stack=&errcontext;
18631863

1864-
TRACE_POSTGRESQL_BUFFER_FLUSH_START(reln->smgr_rnode.spcNode,
1865-
reln->smgr_rnode.dbNode,
1866-
reln->smgr_rnode.relNode);
1867-
18681864
/* Find smgr relation for buffer */
18691865
if (reln==NULL)
18701866
reln=smgropen(buf->tag.rnode);
18711867

1868+
TRACE_POSTGRESQL_BUFFER_FLUSH_START(reln->smgr_rnode.spcNode,
1869+
reln->smgr_rnode.dbNode,
1870+
reln->smgr_rnode.relNode);
1871+
18721872
/*
18731873
* Force XLOG flush up to buffer's LSN. This implements the basic WAL
18741874
* rule that log updates must hit disk before any of the data-file changes

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp