- Notifications
You must be signed in to change notification settings - Fork5
Commitd272244
committed
Fix two bugs in WAL-logging of GIN pending-list pages.
In writeListPage, never take a full-page image of the page, because wehave all the information required to re-initialize in the WAL recordanyway. Before this fix, a full-page image was always generated, unlessfull_page_writes=off, because when the page is initialized its LSN isalways 0. In stable-branches, keep the code to restore the backup blocksif they exist, in case that the WAL is generated with an older minorversion, but in master Assert that there are no full-page images.In the redo routine, add missing "off++". Otherwise the tuples are addedto the page in reverse order. That happens to be harmless because wealways scan and remove all the tuples together, but it was clearly wrong.Also, it was masked by the first bug unless full_page_writes=off, becausethe page was always restored from a full-page image.Backpatch to all supported versions.1 parent728c06f commitd272244
2 files changed
+6
-8
lines changedLines changed: 1 addition & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
119 | 119 |
| |
120 | 120 |
| |
121 | 121 |
| |
122 |
| - | |
123 |
| - | |
| 122 | + | |
124 | 123 |
| |
125 | 124 |
| |
126 | 125 |
| |
|
Lines changed: 5 additions & 6 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
814 | 814 |
| |
815 | 815 |
| |
816 | 816 |
| |
817 |
| - | |
818 |
| - | |
819 |
| - | |
820 |
| - | |
821 |
| - | |
822 |
| - | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
823 | 821 |
| |
824 | 822 |
| |
825 | 823 |
| |
| |||
848 | 846 |
| |
849 | 847 |
| |
850 | 848 |
| |
| 849 | + | |
851 | 850 |
| |
852 | 851 |
| |
853 | 852 |
| |
|
0 commit comments
Comments
(0)