NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitd1c5752

committed

Fix off-by-one in pg_xlogdump's fuzzy_open_file().

In the unlikely case of stdin (fd 0) being closed, the off-by-onewould lead to pg_xlogdump failing to open files.Spotted by Coverity.Backpatch to 9.3 where pg_xlogdump was introduced.

1 parent14570c2 commitd1c5752Copy full SHA for d1c5752

File tree

1 file changed

-5

lines changed

contrib/pg_xlogdump
- pg_xlogdump.c

1 file changed

-5

lines changed

`‎contrib/pg_xlogdump/pg_xlogdump.c`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -171,7 +171,7 @@ fuzzy_open_file(const char directory, const char fname)`
`171`	`171`	`fd=open(fname,O_RDONLY \|PG_BINARY,0);`
`172`	`172`	`if (fd<0&&errno!=ENOENT)`
`173`	`173`	`return-1;`
`174`		`-elseif (fd>0)`
	`174`	`+elseif (fd >=0)`
`175`	`175`	`returnfd;`
`176`	`176`
`177`	`177`	`/* XLOGDIR / fname */`
`@@ -180,7 +180,7 @@ fuzzy_open_file(const char directory, const char fname)`
`180`	`180`	`fd=open(fpath,O_RDONLY \|PG_BINARY,0);`
`181`	`181`	`if (fd<0&&errno!=ENOENT)`
`182`	`182`	`return-1;`
`183`		`-elseif (fd>0)`
	`183`	`+elseif (fd >=0)`
`184`	`184`	`returnfd;`
`185`	`185`
`186`	`186`	`datadir=getenv("PGDATA");`
`@@ -192,7 +192,7 @@ fuzzy_open_file(const char directory, const char fname)`
`192`	`192`	`fd=open(fpath,O_RDONLY \|PG_BINARY,0);`
`193`	`193`	`if (fd<0&&errno!=ENOENT)`
`194`	`194`	`return-1;`
`195`		`-elseif (fd>0)`
	`195`	`+elseif (fd >=0)`
`196`	`196`	`returnfd;`
`197`	`197`	`}`
`198`	`198`	`}`
`@@ -204,7 +204,7 @@ fuzzy_open_file(const char directory, const char fname)`
`204`	`204`	`fd=open(fpath,O_RDONLY \|PG_BINARY,0);`
`205`	`205`	`if (fd<0&&errno!=ENOENT)`
`206`	`206`	`return-1;`
`207`		`-elseif (fd>0)`
	`207`	`+elseif (fd >=0)`
`208`	`208`	`returnfd;`
`209`	`209`
`210`	`210`	`/* directory / XLOGDIR / fname */`
`@@ -213,7 +213,7 @@ fuzzy_open_file(const char directory, const char fname)`
`213`	`213`	`fd=open(fpath,O_RDONLY \|PG_BINARY,0);`
`214`	`214`	`if (fd<0&&errno!=ENOENT)`
`215`	`215`	`return-1;`
`216`		`-elseif (fd>0)`
	`216`	`+elseif (fd >=0)`
`217`	`217`	`returnfd;`
`218`	`218`	`}`
`219`	`219`	`return-1;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd1c5752

File tree

1 file changed

1 file changed

`‎contrib/pg_xlogdump/pg_xlogdump.c`

0 commit comments