NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitd0dcb31

committed

Fix broken logic in lazy_vacuum_heap.

As noted by Tom Lane, the previous coding in this area, which Iintroduced in commitbbb6e55, waspoorly tested and caused the vacuum's second heap to go into what wouldhave been an infinite loop but for the fact that it eventually caused amemory allocation failure. This version seems to work better.

1 parent4d0b11a commitd0dcb31Copy full SHA for d0dcb31

File tree

1 file changed

-0

lines changed

src/backend/commands
- vacuumlazy.c

1 file changed

-0

lines changed

`‎src/backend/commands/vacuumlazy.c`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -991,7 +991,11 @@ lazy_vacuum_heap(Relation onerel, LVRelStats *vacrelstats)`
`991`	`991`	`buf=ReadBufferExtended(onerel,MAIN_FORKNUM,tblk,RBM_NORMAL,`
`992`	`992`	`vac_strategy);`
`993`	`993`	`if (!ConditionalLockBufferForCleanup(buf))`
	`994`	`+{`
	`995`	`+ReleaseBuffer(buf);`
	`996`	`+++tupindex;`
`994`	`997`	`continue;`
	`998`	`+}`
`995`	`999`	`tupindex=lazy_vacuum_page(onerel,tblk,buf,tupindex,vacrelstats);`
`996`	`1000`
`997`	`1001`	`/* Now that we've compacted the page, record its available space */`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitd0dcb31

File tree

1 file changed

1 file changed

`‎src/backend/commands/vacuumlazy.c`

0 commit comments