Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitcef8efc

Browse files
committed
Don't use OidIsValid to check the return value of transformGenericOptions,
because transformGenericOptions returns an array, not an Oid. I'm notsure if this fixes the crashes seen in buildfarm, but it should be fixedanyway.
1 parentea7d519 commitcef8efc

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

‎src/backend/commands/foreigncmds.c

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
*
88
*
99
* IDENTIFICATION
10-
* $PostgreSQL: pgsql/src/backend/commands/foreigncmds.c,v 1.1 2008/12/19 16:25:17 petere Exp $
10+
* $PostgreSQL: pgsql/src/backend/commands/foreigncmds.c,v 1.2 2008/12/20 09:40:56 heikki Exp $
1111
*
1212
*-------------------------------------------------------------------------
1313
*/
@@ -316,7 +316,7 @@ CreateForeignDataWrapper(CreateFdwStmt *stmt)
316316
boolnulls[Natts_pg_foreign_data_wrapper];
317317
HeapTupletuple;
318318
OidfdwId;
319-
Datumfdwoptions=InvalidOid;
319+
Datumfdwoptions;
320320
OidownerId;
321321
ForeignDataWrapperLibrary*fdwlib;
322322

@@ -362,7 +362,7 @@ CreateForeignDataWrapper(CreateFdwStmt *stmt)
362362
fdwoptions=transformGenericOptions(0,stmt->options,FdwOpt,NULL,
363363
fdwlib->validateOptionList);
364364

365-
if (OidIsValid(fdwoptions))
365+
if (PointerIsValid(DatumGetPointer(fdwoptions)))
366366
values[Anum_pg_foreign_data_wrapper_fdwoptions-1]=fdwoptions;
367367
else
368368
nulls[Anum_pg_foreign_data_wrapper_fdwoptions-1]= true;
@@ -465,7 +465,7 @@ AlterForeignDataWrapper(AlterFdwStmt *stmt)
465465
datum=transformGenericOptions(datum,stmt->options,FdwOpt,
466466
NULL,fdwlib->validateOptionList);
467467

468-
if (OidIsValid(datum))
468+
if (PointerIsValid(DatumGetPointer(datum)))
469469
repl_val[Anum_pg_foreign_data_wrapper_fdwoptions-1]=ObjectIdGetDatum(datum);
470470
else
471471
repl_null[Anum_pg_foreign_data_wrapper_fdwoptions-1]= true;
@@ -565,7 +565,7 @@ void
565565
CreateForeignServer(CreateForeignServerStmt*stmt)
566566
{
567567
Relationrel;
568-
Datumsrvoptions=InvalidOid;
568+
Datumsrvoptions;
569569
Datumvalues[Natts_pg_foreign_server];
570570
boolnulls[Natts_pg_foreign_server];
571571
HeapTupletuple;
@@ -631,7 +631,7 @@ CreateForeignServer(CreateForeignServerStmt *stmt)
631631
srvoptions=transformGenericOptions(0,stmt->options,ServerOpt,fdw,
632632
fdw->lib->validateOptionList);
633633

634-
if (OidIsValid(srvoptions))
634+
if (PointerIsValid(DatumGetPointer(srvoptions)))
635635
values[Anum_pg_foreign_server_srvoptions-1]=srvoptions;
636636
else
637637
nulls[Anum_pg_foreign_server_srvoptions-1]= true;
@@ -727,7 +727,7 @@ AlterForeignServer(AlterForeignServerStmt *stmt)
727727
datum=transformGenericOptions(datum,stmt->options,ServerOpt,
728728
fdw,fdw->lib->validateOptionList);
729729

730-
if (OidIsValid(datum))
730+
if (PointerIsValid(DatumGetPointer(datum)))
731731
repl_val[Anum_pg_foreign_server_srvoptions-1]=datum;
732732
else
733733
repl_null[Anum_pg_foreign_server_srvoptions-1]= true;
@@ -822,7 +822,7 @@ void
822822
CreateUserMapping(CreateUserMappingStmt*stmt)
823823
{
824824
Relationrel;
825-
Datumuseoptions=InvalidOid;
825+
Datumuseoptions;
826826
Datumvalues[Natts_pg_user_mapping];
827827
boolnulls[Natts_pg_user_mapping];
828828
HeapTupletuple;
@@ -877,7 +877,7 @@ CreateUserMapping(CreateUserMappingStmt *stmt)
877877
useoptions=transformGenericOptions(0,stmt->options,UserMappingOpt,
878878
fdw,fdw->lib->validateOptionList);
879879

880-
if (OidIsValid(useoptions))
880+
if (PointerIsValid(DatumGetPointer(useoptions)))
881881
values[Anum_pg_user_mapping_umoptions-1]=useoptions;
882882
else
883883
nulls[Anum_pg_user_mapping_umoptions-1]= true;
@@ -977,7 +977,7 @@ AlterUserMapping(AlterUserMappingStmt *stmt)
977977
datum=transformGenericOptions(datum,stmt->options,UserMappingOpt,
978978
fdw,fdw->lib->validateOptionList);
979979

980-
if (OidIsValid(datum))
980+
if (PointerIsValid(DatumGetPointer(datum)))
981981
repl_val[Anum_pg_user_mapping_umoptions-1]=datum;
982982
else
983983
repl_null[Anum_pg_user_mapping_umoptions-1]= true;

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp