NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitcec62ef

committed

Be sure to close() file descriptor on error case

In receivelog.c:writeTimeLineHistoryFile(), we were not properlyclosing the open'd file descriptor in error cases. While thiswouldn't matter much if we were about to exit due to such anerror, that's not the case with pg_receivexlog as it can be along-running process and these errors are non-fatal.This resource leak was found by the Coverity scanner.Back-patch to 9.3 where this issue first appeared.

1 parent273dcd1 commitcec62efCopy full SHA for cec62ef

File tree

1 file changed

-0

lines changed

src/bin/pg_basebackup
- receivelog.c

1 file changed

-0

lines changed

`‎src/bin/pg_basebackup/receivelog.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -329,6 +329,7 @@ writeTimeLineHistoryFile(char basedir, TimeLineID tli, char filename, char *co`
`329`	`329`	`/*`
`330`	`330`	`* If we fail to make the file, delete it to release disk space`
`331`	`331`	`*/`
	`332`	`+close(fd);`
`332`	`333`	`unlink(tmppath);`
`333`	`334`	`errno=save_errno;`
`334`	`335`
`@@ -339,6 +340,7 @@ writeTimeLineHistoryFile(char basedir, TimeLineID tli, char filename, char *co`
`339`	`340`
`340`	`341`	`if (fsync(fd)!=0)`
`341`	`342`	`{`
	`343`	`+close(fd);`
`342`	`344`	`fprintf(stderr,_("%s: could not fsync file \"%s\": %s\n"),`
`343`	`345`	`progname,tmppath,strerror(errno));`
`344`	`346`	`return false;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcec62ef

File tree

1 file changed

1 file changed

`‎src/bin/pg_basebackup/receivelog.c`

0 commit comments