NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitce4dc97

committed

Remove invitation to report a bug about unknown encoding

The error message when we couldn't determine the encoding from a localesaid to report a bug about that. That might have been appropriate whenthis code was first added, but by now this works pretty solidly and anyencodings we don't recognize we probably just don't support. We stillprint the warning, but no longer invite the bug report.

1 parenteaed88c commitce4dc97Copy full SHA for ce4dc97

File tree

1 file changed

-4

lines changed

src/port
- chklocale.c

1 file changed

-4

lines changed

`‎src/port/chklocale.c`

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -290,8 +290,7 @@ pg_codepage_to_encoding(UINT cp)`
`290`	`290`	`returnencoding_match_list[i].pg_enc_code;`
`291`	`291`
`292`	`292`	`ereport(WARNING,`
`293`		`-(errmsg("could not determine encoding for codeset \"%s\"",sys),`
`294`		`-errdetail("Please report this to <pgsql-bugs@postgresql.org>.")));`
	`293`	`+(errmsg("could not determine encoding for codeset \"%s\"",sys)));`
`295`	`294`
`296`	`295`	`return-1;`
`297`	`296`	`}`
`@@ -419,8 +418,7 @@ pg_get_encoding_from_locale(const char *ctype, bool write_message)`
`419`	`418`	`#else`
`420`	`419`	`ereport(WARNING,`
`421`	`420`	`(errmsg("could not determine encoding for locale \"%s\": codeset is \"%s\"",`
`422`		`-ctype,sys),`
`423`		`-errdetail("Please report this to <pgsql-bugs@postgresql.org>.")));`
	`421`	`+ctype,sys)));`
`424`	`422`	`#endif`
`425`	`423`	`}`
`426`	`424`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitce4dc97

File tree

1 file changed

1 file changed

`‎src/port/chklocale.c`

0 commit comments