NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitcd0e825

committed

Fix msvc build for localized versions of Visual C++

Look only at the non-localized part of the output from "vcbuild /?",which is used to determine the version of Visual Studio in use. Differentlanguages seem to localize different amounts of the string, but we assumethe part "Microsoft Visual C++" won't be modified.

1 parent9771125 commitcd0e825Copy full SHA for cd0e825

File tree

1 file changed

-1

lines changed

src/tools/msvc
- Solution.pm

1 file changed

-1

lines changed

`‎src/tools/msvc/Solution.pm`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ sub DetermineToolVersions`
`66`	`66`	`open(P,"vcbuild /? \|") \|\|die"vcbuild command not found";`
`67`	`67`	`my$line = <P>;`
`68`	`68`	`close(P);`
`69`		`-if ($line !~/^Microsoft\s*$R$ Visual C\+\+Project Builder -\D+(\d+)\.00\.\d+/)`
	`69`	`+if ($line !~/^Microsoft\s*$R$ Visual C\+\+[^-]+ -\D+(\d+)\.00\.\d+/)`
`70`	`70`	`{`
`71`	`71`	`die"Unable to determine vcbuild version from first line of output!";`
`72`	`72`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitcd0e825

File tree

1 file changed

1 file changed

`‎src/tools/msvc/Solution.pm`

0 commit comments