Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commitcc62dc2

Browse files
committed
Fix tuplecmp() to ensure repeatable sort ordering of tuples
that contain null fields. Old code would produce erratic sort resultsbecause comparisons of tuples containing nulls could produce inconsistentanswers.
1 parentbc5f34c commitcc62dc2

File tree

1 file changed

+32
-24
lines changed

1 file changed

+32
-24
lines changed

‎src/backend/utils/sort/lselect.c

Lines changed: 32 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $Header: /cvsroot/pgsql/src/backend/utils/sort/Attic/lselect.c,v 1.15 1999/02/13 23:20:15 momjian Exp $
11+
* $Header: /cvsroot/pgsql/src/backend/utils/sort/Attic/lselect.c,v 1.16 1999/07/10 18:21:59 tgl Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -186,41 +186,49 @@ puttuple(struct leftist ** treep,
186186
int
187187
tuplecmp(HeapTupleltup,HeapTuplertup,LeftistContextcontext)
188188
{
189-
Datumlattr,
190-
rattr;
191-
intnkey=0;
189+
intnkey;
192190
intresult=0;
193-
boolisnull;
194191

195192
if (ltup== (HeapTuple)NULL)
196193
return0;
197194
if (rtup== (HeapTuple)NULL)
198195
return1;
199-
while (nkey<context->nKeys&& !result)
196+
for (nkey=0;nkey<context->nKeys;nkey++)
200197
{
201-
lattr=heap_getattr(ltup,
202-
context->scanKeys[nkey].sk_attno,
203-
context->tupDesc,&isnull);
204-
if (isnull)
205-
return0;
206-
rattr=heap_getattr(rtup,
207-
context->scanKeys[nkey].sk_attno,
208-
context->tupDesc,
209-
&isnull);
210-
if (isnull)
198+
ScanKeythisKey=&context->scanKeys[nkey];
199+
Datumlattr,
200+
rattr;
201+
boollisnull,
202+
risnull;
203+
204+
lattr=heap_getattr(ltup,thisKey->sk_attno,
205+
context->tupDesc,&lisnull);
206+
rattr=heap_getattr(rtup,thisKey->sk_attno,
207+
context->tupDesc,&risnull);
208+
if (lisnull)
209+
{
210+
if (risnull)
211+
continue;/* treat two nulls as equal */
212+
return0;/* else, a null sorts after all else */
213+
}
214+
if (risnull)
211215
return1;
212-
if (context->scanKeys[nkey].sk_flags&SK_COMMUTE)
216+
if (thisKey->sk_flags&SK_COMMUTE)
217+
{
218+
if (!(result=
219+
(long) (*fmgr_faddr(&thisKey->sk_func)) (rattr,lattr)))
220+
result=
221+
-(long) (*fmgr_faddr(&thisKey->sk_func)) (lattr,rattr);
222+
}
223+
else
213224
{
214225
if (!(result=
215-
(long) (*fmgr_faddr(&context->scanKeys[nkey].sk_func)) (rattr,lattr)))
226+
(long) (*fmgr_faddr(&thisKey->sk_func)) (lattr,rattr)))
216227
result=
217-
-(long) (*fmgr_faddr(&context->scanKeys[nkey].sk_func)) (lattr,rattr);
228+
-(long) (*fmgr_faddr(&thisKey->sk_func)) (rattr,lattr);
218229
}
219-
elseif (!(result=
220-
(long) (*fmgr_faddr(&context->scanKeys[nkey].sk_func)) (lattr,rattr)))
221-
result=
222-
-(long) (*fmgr_faddr(&context->scanKeys[nkey].sk_func)) (rattr,lattr);
223-
nkey++;
230+
if (result)
231+
break;
224232
}
225233
returnresult==1;
226234
}

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp