- Notifications
You must be signed in to change notification settings - Fork5
Commitcb7c84f
committed
Check misplaced window functions before checking aggregate/group by sanity.
If somebody puts a window function in WHERE, we should complain about thatin so many words. The previous coding tended to complain about the windowfunction's arguments instead, which is likely to be misleading to users whoare unclear on the semantics of window functions; as seen for example inbug #6440 from Matyas Novak.Just another example of how "add new code at the end" is frequently a badheuristic.1 parentcbba55d commitcb7c84f
1 file changed
+9
-9
lines changedLines changed: 9 additions & 9 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
316 | 316 |
| |
317 | 317 |
| |
318 | 318 |
| |
319 |
| - | |
320 |
| - | |
321 |
| - | |
322 | 319 |
| |
323 | 320 |
| |
324 | 321 |
| |
| 322 | + | |
| 323 | + | |
| 324 | + | |
325 | 325 |
| |
326 | 326 |
| |
327 | 327 |
| |
| |||
970 | 970 |
| |
971 | 971 |
| |
972 | 972 |
| |
973 |
| - | |
974 |
| - | |
975 |
| - | |
976 | 973 |
| |
977 | 974 |
| |
978 | 975 |
| |
| 976 | + | |
| 977 | + | |
| 978 | + | |
979 | 979 |
| |
980 | 980 |
| |
981 | 981 |
| |
| |||
1448 | 1448 |
| |
1449 | 1449 |
| |
1450 | 1450 |
| |
1451 |
| - | |
1452 |
| - | |
1453 |
| - | |
1454 | 1451 |
| |
1455 | 1452 |
| |
1456 | 1453 |
| |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
1457 | 1457 |
| |
1458 | 1458 |
| |
1459 | 1459 |
| |
|
0 commit comments
Comments
(0)