Commitca3f43a

committed

Change TAP test framework to not rely on having a chmod executable.

This might not work at all on Windows, and is not ever efficient.Michael Paquier

1 parentb76e76b commitca3f43aCopy full SHA for ca3f43a

File tree

+16

-2

lines changed

+16

-2

lines changed

Lines changed: 15 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -43,6 +43,20 @@ sub copy_files`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`
	`46`	`+# Perform chmod on a set of files, taking into account wildcards`
	`47`	`+subchmod_files`
	`48`	`+{`
	`49`	`+my$mode =shift;`
	`50`	`+my$file_expr =shift;`
	`51`	`+`
	`52`	`+my@all_files =glob$file_expr;`
	`53`	`+foreachmy$file_entry (@all_files)`
	`54`	`+{`
	`55`	`+chmod$mode,$file_entry`
	`56`	`+ordie"Could not run chmod with mode$mode on$file_entry";`
	`57`	`+}`
	`58`	`+}`
	`59`	`+`
`46`	`60`	`subconfigure_test_server_for_ssl`
`47`	`61`	`{`
`48`	`62`	`my$tempdir =$_[0];`
`@@ -68,7 +82,7 @@ sub configure_test_server_for_ssl`
`68`	`82`	`# Copy all server certificates and keys, and client root cert, to the data dir`
`69`	`83`	`copy_files("ssl/server-*.crt","$tempdir/pgdata");`
`70`	`84`	`copy_files("ssl/server-*.key","$tempdir/pgdata");`
`71`		`-system_or_bail"chmod0600 '$tempdir'/pgdata/server-*.key";`
	`85`	`+chmod_files(0600,"$tempdir/pgdata/server-*.key");`
`72`	`86`	`copy_files("ssl/root+client_ca.crt","$tempdir/pgdata");`
`73`	`87`	`copy_files("ssl/root+client.crl","$tempdir/pgdata");`
`74`	`88`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ sub test_connect_fails`
`78`	`78`	`# The client's private key must not be world-readable. Git doesn't track`
`79`	`79`	`# permissions (except for the executable bit), so they might be wrong after`
`80`	`80`	`# a checkout.`
`81`		`-system_or_bail"chmod 0600ssl/client.key";`
	`81`	`+chmod 0600,"ssl/client.key";`
`82`	`82`
`83`	`83`	`#### Part 0. Set up the server.`
`84`	`84`

Comments

(0)