NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitc9d7dba

committed

Skip truncating ON COMMIT DELETE ROWS temp tables, if the transaction hasn't

touched any temporary tables.We could try harder, and keep track of whether we've inserted to any temptables, rather than accessed them, and which temp tables have been insertedto. But this is dead simple, and already covers many interesting scenarios.

1 parentfd4ced5 commitc9d7dbaCopy full SHA for c9d7dba

File tree

1 file changed

-1

lines changed

src/backend/commands
- tablecmds.c

1 file changed

-1

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10124,7 +10124,13 @@ PreCommit_on_commit_actions(void)`
`10124`	`10124`	`/* Do nothing (there shouldn't be such entries, actually) */`
`10125`	`10125`	`break;`
`10126`	`10126`	`caseONCOMMIT_DELETE_ROWS:`
`10127`		`-oids_to_truncate=lappend_oid(oids_to_truncate,oc->relid);`
	`10127`	`+/*`
	`10128`	`+ * If this transaction hasn't accessed any temporary`
	`10129`	`+ * relations, we can skip truncating ON COMMIT DELETE ROWS`
	`10130`	`+ * tables, as they must still be empty.`
	`10131`	`+ */`
	`10132`	`+if (MyXactAccessedTempRel)`
	`10133`	`+oids_to_truncate=lappend_oid(oids_to_truncate,oc->relid);`
`10128`	`10134`	`break;`
`10129`	`10135`	`caseONCOMMIT_DROP:`
`10130`	`10136`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc9d7dba

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablecmds.c`

0 commit comments