Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitc67f6f2

Browse files
committed
Reducing the assumed alignment of struct varlena means that the compiler
is also licensed to put a local variable declared that way at an unalignedaddress. Which will not work if the variable is then manipulated withSET_VARSIZE or other macros that assume alignment. So the previous patchis not an unalloyed good, but on balance I think it's still a win, sincewe have very few places that do that sort of thing. Fix the one place intuptoaster.c that does it. Per buildfarm results from gypsy_moth(I'm a bit surprised that only one machine showed a failure).
1 parent2d2b022 commitc67f6f2

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

‎src/backend/access/heap/tuptoaster.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/access/heap/tuptoaster.c,v 1.82 2008/02/23 19:11:45 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/access/heap/tuptoaster.c,v 1.83 2008/02/29 17:47:41 tgl Exp $
1212
*
1313
*
1414
* INTERFACE ROUTINES
@@ -1093,7 +1093,8 @@ toast_save_datum(Relation rel, Datum value,
10931093
struct
10941094
{
10951095
structvarlenahdr;
1096-
chardata[TOAST_MAX_CHUNK_SIZE];
1096+
chardata[TOAST_MAX_CHUNK_SIZE];/* make struct big enough */
1097+
int32align_it;/* ensure struct is aligned well enough */
10971098
}chunk_data;
10981099
int32chunk_size;
10991100
int32chunk_seq=0;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp