- Notifications
You must be signed in to change notification settings - Fork5
Commitc5f11f9
committed
Fix a number of places that were making file-type tests infelicitously.
The places that did, eg,(statbuf.st_mode & S_IFMT) == S_IFDIRwere correct, but there is no good reason not to use S_ISDIR() instead,especially when that's what the other 90% of our code does. The placesthat did, eg,(statbuf.st_mode & S_IFDIR)were flat out *wrong* and would fail in various platform-specific ways,eg a symlink could be mistaken for a regular file on most Unixen.The actual impact of this is probably small, since the problem casesseem to always involve symlinks or sockets, which are unlikely to befound in the directories that PG code might be scanning. But it'sclearly trouble waiting to happen, so patch all the way back anyway.(There seem to be no occurrences of the mistake in 7.4.)1 parentb65a509 commitc5f11f9
File tree
5 files changed
+14
-14
lines changed- src
- backend/utils/adt
- port
- test/regress
5 files changed
+14
-14
lines changedLines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
5 | 5 |
| |
6 | 6 |
| |
7 | 7 |
| |
8 |
| - | |
| 8 | + | |
9 | 9 |
| |
10 | 10 |
| |
11 | 11 |
| |
| |||
209 | 209 |
| |
210 | 210 |
| |
211 | 211 |
| |
212 |
| - | |
| 212 | + | |
213 | 213 |
| |
214 | 214 |
| |
215 | 215 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
9 | 9 |
| |
10 | 10 |
| |
11 | 11 |
| |
12 |
| - | |
| 12 | + | |
13 | 13 |
| |
14 | 14 |
| |
15 | 15 |
| |
| |||
198 | 198 |
| |
199 | 199 |
| |
200 | 200 |
| |
201 |
| - | |
| 201 | + | |
202 | 202 |
| |
203 | 203 |
| |
204 | 204 |
| |
|
Lines changed: 3 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
11 | 11 |
| |
12 | 12 |
| |
13 | 13 |
| |
14 |
| - | |
| 14 | + | |
15 | 15 |
| |
16 | 16 |
| |
17 | 17 |
| |
| |||
80 | 80 |
| |
81 | 81 |
| |
82 | 82 |
| |
83 |
| - | |
| 83 | + | |
84 | 84 |
| |
85 | 85 |
| |
86 | 86 |
| |
87 | 87 |
| |
88 | 88 |
| |
89 |
| - | |
| 89 | + | |
90 | 90 |
| |
91 | 91 |
| |
92 | 92 |
| |
|
Lines changed: 5 additions & 5 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
9 | 9 |
| |
10 | 10 |
| |
11 | 11 |
| |
12 |
| - | |
| 12 | + | |
13 | 13 |
| |
14 | 14 |
| |
15 | 15 |
| |
| |||
80 | 80 |
| |
81 | 81 |
| |
82 | 82 |
| |
83 |
| - | |
84 |
| - | |
| 83 | + | |
| 84 | + | |
85 | 85 |
| |
86 | 86 |
| |
87 | 87 |
| |
| |||
103 | 103 |
| |
104 | 104 |
| |
105 | 105 |
| |
106 |
| - | |
| 106 | + | |
107 | 107 |
| |
108 | 108 |
| |
109 | 109 |
| |
| |||
331 | 331 |
| |
332 | 332 |
| |
333 | 333 |
| |
334 |
| - | |
| 334 | + | |
335 | 335 |
| |
336 | 336 |
| |
337 | 337 |
| |
|
Lines changed: 2 additions & 2 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
11 | 11 |
| |
12 | 12 |
| |
13 | 13 |
| |
14 |
| - | |
| 14 | + | |
15 | 15 |
| |
16 | 16 |
| |
17 | 17 |
| |
| |||
1102 | 1102 |
| |
1103 | 1103 |
| |
1104 | 1104 |
| |
1105 |
| - | |
| 1105 | + | |
1106 | 1106 |
| |
1107 | 1107 |
| |
1108 | 1108 |
| |
|
0 commit comments
Comments
(0)