NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitc39f567

committed

Fix brin index summarizing while vacuuming.

If the number of heap blocks is not multiples of pages per range, thesummarizing produces wrong summary information for the last brin indextuple while vacuuming.Problem reported by Tatsuo Ishii and fixed by Amit Langote.Discussion at "[HACKERS] BRIN INDEX value (message id :20150903.174935.1946402199422994347.t-ishii@sraoss.co.jp)Backpatched to 9.5 in which brin index was added.

1 parentc5454f9 commitc39f567Copy full SHA for c39f567

File tree

1 file changed

-3

lines changed

src/backend/access/brin
- brin.c

1 file changed

-3

lines changed

`‎src/backend/access/brin/brin.c`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -934,12 +934,13 @@ terminate_brin_buildstate(BrinBuildState *state)`
`934`	`934`	`*/`
`935`	`935`	`staticvoid`
`936`	`936`	`summarize_range(IndexInfoindexInfo,BrinBuildStatestate,RelationheapRel,`
`937`		`-BlockNumberheapBlk)`
	`937`	`+BlockNumberheapBlk,BlockNumberheapNumBlks)`
`938`	`938`	`{`
`939`	`939`	`Bufferphbuf;`
`940`	`940`	`BrinTuple*phtup;`
`941`	`941`	`Sizephsz;`
`942`	`942`	`OffsetNumberoffset;`
	`943`	`+BlockNumberscanNumBlks;`
`943`	`944`
`944`	`945`	`/*`
`945`	`946`	`* Insert the placeholder tuple`
`@@ -960,8 +961,10 @@ summarize_range(IndexInfo indexInfo, BrinBuildState state, Relation heapRel,`
`960`	`961`	`* by transactions that are still in progress, among other corner cases.`
`961`	`962`	`*/`
`962`	`963`	`state->bs_currRangeStart=heapBlk;`
	`964`	`+scanNumBlks=heapBlk+state->bs_pagesPerRange <=heapNumBlks ?`
	`965`	`+state->bs_pagesPerRange :heapNumBlks-heapBlk;`
`963`	`966`	`IndexBuildHeapRangeScan(heapRel,state->bs_irel,indexInfo, false, true,`
`964`		`-heapBlk,state->bs_pagesPerRange,`
	`967`	`+heapBlk,scanNumBlks,`
`965`	`968`	`brinbuildCallback, (void*)state);`
`966`	`969`
`967`	`970`	`/*`
`@@ -1066,7 +1069,7 @@ brinsummarize(Relation index, Relation heapRel, double *numSummarized,`
`1066`	`1069`	`pagesPerRange);`
`1067`	`1070`	`indexInfo=BuildIndexInfo(index);`
`1068`	`1071`	`}`
`1069`		`-summarize_range(indexInfo,state,heapRel,heapBlk);`
	`1072`	`+summarize_range(indexInfo,state,heapRel,heapBlk,heapNumBlocks);`
`1070`	`1073`
`1071`	`1074`	`/* and re-initialize state for the next range */`
`1072`	`1075`	`brin_memtuple_initialize(state->bs_dtuple,state->bs_bdesc);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc39f567

File tree

1 file changed

1 file changed

`‎src/backend/access/brin/brin.c`

0 commit comments