Commitc2a2f75

committed

Avoid double close of file handle in syslogger on win32

This causes an exception when running under a debugger or in particularwhen running on a debug version of Windows.Patch from MauMau

1 parent6b044cb commitc2a2f75Copy full SHA for c2a2f75

File tree

-2

lines changed

-2

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -588,8 +588,11 @@ SysLogger_Start(void)`
`588`	`588`	`errmsg("could not redirect stderr: %m")));`
`589`	`589`	`close(fd);`
`590`	`590`	`_setmode(_fileno(stderr),_O_BINARY);`
`591`		`-/* Now we are done with the write end of the pipe. */`
`592`		`-CloseHandle(syslogPipe[1]);`
	`591`	`+/*`
	`592`	`+ * Now we are done with the write end of the pipe.`
	`593`	`+ * CloseHandle() must not be called because the preceding`
	`594`	`+ * close() closes the underlying handle.`
	`595`	`+*/`
`593`	`596`	`syslogPipe[1]=0;`
`594`	`597`	`#endif`
`595`	`598`	`redirection_done= true;`

Comments

(0)