NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitc250994

committed

Fix bug slowing down pgbench when -P is used.

A removed check inba3deee made all threads but the main one busy-loopwhen -P was used. All threads computed the time to the next time theprogress report should be printed, but only the main thread did so andre-scheduled it only for the future.Reported-By: Jesper PedersenDiscussion: 55C4E190.3050104@redhat.com

1 parent89db839 commitc250994Copy full SHA for c250994

File tree

1 file changed

-1

lines changed

src/bin/pgbench
- pgbench.c

1 file changed

-1

lines changed

`‎src/bin/pgbench/pgbench.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3646,7 +3646,7 @@ threadRun(void *arg)`
`3646`	`3646`	`}`
`3647`	`3647`
`3648`	`3648`	`/* also wake up to print the next progress report on time */`
`3649`		`-if (progress&&min_usec>0)`
	`3649`	`+if (progress&&min_usec>0&&thread->tid==0)`
`3650`	`3650`	`{`
`3651`	`3651`	`/* get current time if needed */`
`3652`	`3652`	`if (now_usec==0)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc250994

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/pgbench.c`

0 commit comments