NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitc1e0e7e

committed

Speed up dropping tables with many partitions.

We need to lock the parent, but we don't need a relcache entryfor it.Gao Zeng Qi, reviewed by Amit LangoteDiscussion:http://postgr.es/m/CAFmBtr0ukqJjRJEhPWL5wt4rNMrJUUxggVAGXPR3SyYh3E+HDQ@mail.gmail.com

1 parent504c220 commitc1e0e7eCopy full SHA for c1e0e7e

File tree

1 file changed

-6

lines changed

src/backend/catalog
- heap.c

1 file changed

-6

lines changed

`‎src/backend/catalog/heap.c`

Lines changed: 6 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,7 @@`
`68`	`68`	`#include"parser/parse_collate.h"`
`69`	`69`	`#include"parser/parse_expr.h"`
`70`	`70`	`#include"parser/parse_relation.h"`
	`71`	`+#include"storage/lmgr.h"`
`71`	`72`	`#include"storage/predicate.h"`
`72`	`73`	`#include"storage/smgr.h"`
`73`	`74`	`#include"utils/acl.h"`
`@@ -1760,8 +1761,7 @@ heap_drop_with_catalog(Oid relid)`
`1760`	`1761`	`{`
`1761`	`1762`	`Relationrel;`
`1762`	`1763`	`HeapTupletuple;`
`1763`		`-OidparentOid;`
`1764`		`-Relationparent=NULL;`
	`1764`	`+OidparentOid=InvalidOid;`
`1765`	`1765`
`1766`	`1766`	`/*`
`1767`	`1767`	`* To drop a partition safely, we must grab exclusive lock on its parent,`
`@@ -1776,7 +1776,7 @@ heap_drop_with_catalog(Oid relid)`
`1776`	`1776`	`if (((Form_pg_class)GETSTRUCT(tuple))->relispartition)`
`1777`	`1777`	`{`
`1778`	`1778`	`parentOid=get_partition_parent(relid);`
`1779`		`-parent=heap_open(parentOid,AccessExclusiveLock);`
	`1779`	`+LockRelationOid(parentOid,AccessExclusiveLock);`
`1780`	`1780`	`}`
`1781`	`1781`
`1782`	`1782`	`ReleaseSysCache(tuple);`
`@@ -1885,14 +1885,14 @@ heap_drop_with_catalog(Oid relid)`
`1885`	`1885`	`*/`
`1886`	`1886`	`DeleteRelationTuple(relid);`
`1887`	`1887`
`1888`		`-if (parent)`
	`1888`	`+if (OidIsValid(parentOid))`
`1889`	`1889`	`{`
`1890`	`1890`	`/*`
`1891`	`1891`	`* Invalidate the parent's relcache so that the partition is no longer`
`1892`	`1892`	`* included in its partition descriptor.`
`1893`	`1893`	`*/`
`1894`		`-CacheInvalidateRelcache(parent);`
`1895`		`-heap_close(parent,NoLock);/* keep the lock */`
	`1894`	`+CacheInvalidateRelcacheByRelid(parentOid);`
	`1895`	`+/* keep the lock */`
`1896`	`1896`	`}`
`1897`	`1897`	`}`
`1898`	`1898`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitc1e0e7e

File tree

1 file changed

1 file changed

`‎src/backend/catalog/heap.c`

0 commit comments