- Notifications
You must be signed in to change notification settings - Fork5
Commitbf7b169
committed
Lots of comment-fixing, and minor cosmetic cleanup, in pg_dump/parallel.c.
The commentary in this file was in extremely sad shape. The author(s)had clearly never heard of the project convention that a function headercomment should provide an API spec of some sort for that function. Muchof it was flat out wrong, too --- maybe it was accurate when written, butif so it had not been updated to track subsequent code revisions. Rewriteand rearrange to try to bring it up to speed, and annotate some of theplaces where more work is needed. (I've refrained from actually fixinganything of substance ... yet.)Also, rename a couple of functions for more clarity as to what they do,do some very minor code rearrangement, remove some pointless Asserts,fix an incorrect Assert in readMessageFromPipe, and add a missing socketclose in one error exit from pgpipe(). The last would be a bug if wetried to continue after pgpipe() failure, but since we don't, it's justcosmetic at present.Although this is only cosmetic, back-patch to 9.3 where parallel.c wasadded. It's sufficiently invasive that it'll pose a hazard for futureback-patching if we don't.Discussion: <25239.1464386067@sss.pgh.pa.us>1 parent715db0b commitbf7b169
2 files changed
+357
-275
lines changed0 commit comments
Comments
(0)