Commitbe92647

committed

Make pg_dump exclude unlogged table data on hot standby slaves

Noted by Joe Van Dyk

1 parent760f3c0 commitbe92647Copy full SHA for be92647

File tree

+20

-1

lines changed

+20

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -713,7 +713,8 @@ PostgreSQL documentation`
`713`	`713`	`<para>`
`714`	`714`	`Do not dump the contents of unlogged tables. This option has no`
`715`	`715`	`effect on whether or not the table definitions (schema) are dumped;`
`716`		`- it only suppresses dumping the table data.`
	`716`	`+ it only suppresses dumping the table data. Data in unlogged tables`
	`717`	`+ is always excluded when dumping from a standby server.`
`717`	`718`	`</para>`
`718`	`719`	`</listitem>`
`719`	`720`	`</varlistentry>`

Lines changed: 18 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -605,6 +605,24 @@ main(int argc, char **argv)`
`605`	`605`	`if (fout->remoteVersion<90100)`
`606`	`606`	`no_security_labels=1;`
`607`	`607`
	`608`	`+/*`
	`609`	`+ * When running against 9.0 or later, check if we are in recovery mode,`
	`610`	`+ * which means we are on a hot standby.`
	`611`	`+ */`
	`612`	`+if (fout->remoteVersion >=90000)`
	`613`	`+{`
	`614`	`+PGresult*res=ExecuteSqlQueryForSingleRow(fout,"SELECT pg_catalog.pg_is_in_recovery()");`
	`615`	`+if (strcmp(PQgetvalue(res,0,0),"t")==0)`
	`616`	`+{`
	`617`	`+/*`
	`618`	`+ * On hot standby slaves, never try to dump unlogged table data,`
	`619`	`+ * since it will just throw an error.`
	`620`	`+ */`
	`621`	`+no_unlogged_table_data= true;`
	`622`	`+}`
	`623`	`+PQclear(res);`
	`624`	`+}`
	`625`	`+`
`608`	`626`	`/*`
`609`	`627`	`* Start transaction-snapshot mode transaction to dump consistent data.`
`610`	`628`	`*/`

Comments

(0)