NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitbd905a0

committed

Fix possible NULL dereference in ExecAlterObjectDependsStmt

I used the wrong variable here. Doesn't make a difference today becausethe only plausible caller passes a non-NULL variable, but someday itwill be wrong, and even today's correctness is subtle: the caller thatdoes pass a NULL is never invoked because of object type constraints.Surely not a condition to rely on.Noted by Coverity

1 parent660d5fb commitbd905a0Copy full SHA for bd905a0

File tree

1 file changed

-1

lines changed

src/backend/commands
- alter.c

1 file changed

-1

lines changed

`‎src/backend/commands/alter.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,7 @@ ExecAlterObjectDependsStmt(AlterObjectDependsStmt stmt, ObjectAddress refAddre`
`422`	`422`	`if (refAddress)`
`423`	`423`	`*refAddress=refAddr;`
`424`	`424`
`425`		`-recordDependencyOn(&address,refAddress,DEPENDENCY_AUTO_EXTENSION);`
	`425`	`+recordDependencyOn(&address,&refAddr,DEPENDENCY_AUTO_EXTENSION);`
`426`	`426`
`427`	`427`	`returnaddress;`
`428`	`428`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbd905a0

File tree

1 file changed

1 file changed

`‎src/backend/commands/alter.c`

0 commit comments