NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitba66c9d

committed

Add missing pstrdup calls

The one for the OCLASS_COLLATION case was noticed byCLOBBER_CACHE_ALWAYS buildfarm members; the others I spotted by manualcode inspection.Also remove a redundant check.

1 parentc168c88 commitba66c9dCopy full SHA for ba66c9d

File tree

1 file changed

-10

lines changed

src/backend/catalog
- objectaddress.c

1 file changed

-10

lines changed

`‎src/backend/catalog/objectaddress.c‎`

Lines changed: 5 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -1513,12 +1513,6 @@ pg_get_object_address(PG_FUNCTION_ARGS)`
`1513`	`1513`	`*/`
`1514`	`1514`	`switch (type)`
`1515`	`1515`	`{`
`1516`		`-caseOBJECT_LARGEOBJECT:`
`1517`		`-if (list_length(name)!=1)`
`1518`		`-ereport(ERROR,`
`1519`		`-(errcode(ERRCODE_INVALID_PARAMETER_VALUE),`
`1520`		`-errmsg("name list length must be exactly %d",1)));`
`1521`		`-break;`
`1522`	`1516`	`caseOBJECT_DOMCONSTRAINT:`
`1523`	`1517`	`caseOBJECT_OPCLASS:`
`1524`	`1518`	`caseOBJECT_OPFAMILY:`
`@@ -3370,7 +3364,8 @@ getObjectIdentityParts(const ObjectAddress *object,`
`3370`	`3364`	`quote_qualified_identifier(schema,`
`3371`	`3365`	`NameStr(coll->collname)));`
`3372`	`3366`	`if (objname)`
`3373`		`-*objname=list_make2(schema,NameStr(coll->collname));`
	`3367`	`+*objname=list_make2(schema,`
	`3368`	`+pstrdup(NameStr(coll->collname)));`
`3374`	`3369`	`ReleaseSysCache(collTup);`
`3375`	`3370`	`break;`
`3376`	`3371`	`}`
`@@ -3667,7 +3662,7 @@ getObjectIdentityParts(const ObjectAddress *object,`
`3667`	`3662`	`quote_identifier(NameStr(rule->rulename)));`
`3668`	`3663`	`getRelationIdentity(&buffer,rule->ev_class,objname);`
`3669`	`3664`	`if (objname)`
`3670`		`-objname=lappend(objname,NameStr(rule->rulename));`
	`3665`	`+objname=lappend(objname,pstrdup(NameStr(rule->rulename)));`
`3671`	`3666`
`3672`	`3667`	`heap_close(ruleDesc,AccessShareLock);`
`3673`	`3668`	`break;`
`@@ -3693,7 +3688,7 @@ getObjectIdentityParts(const ObjectAddress *object,`
`3693`	`3688`	`quote_identifier(NameStr(trig->tgname)));`
`3694`	`3689`	`getRelationIdentity(&buffer,trig->tgrelid,objname);`
`3695`	`3690`	`if (objname)`
`3696`		`-objname=lappend(objname,NameStr(trig->tgname));`
	`3691`	`+objname=lappend(objname,pstrdup(NameStr(trig->tgname)));`
`3697`	`3692`
`3698`	`3693`	`heap_close(trigDesc,AccessShareLock);`
`3699`	`3694`	`break;`
`@@ -3719,7 +3714,7 @@ getObjectIdentityParts(const ObjectAddress *object,`
`3719`	`3714`	`quote_identifier(NameStr(policy->polname)));`
`3720`	`3715`	`getRelationIdentity(&buffer,policy->polrelid,objname);`
`3721`	`3716`	`if (objname)`
`3722`		`-objname=lappend(objname,NameStr(policy->polname));`
	`3717`	`+objname=lappend(objname,pstrdup(NameStr(policy->polname)));`
`3723`	`3718`
`3724`	`3719`	`heap_close(polDesc,AccessShareLock);`
`3725`	`3720`	`break;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitba66c9d

File tree

1 file changed

1 file changed

`‎src/backend/catalog/objectaddress.c‎`

0 commit comments