NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitb7b5a18

committed

In pg_ctl, report unexpected failure to stat() the postmaster.pid file.

Any error other than ENOENT is a bit suspicious here, and perhaps shouldnot be grounds for assuming the postmaster has failed. For the momentthough, just report it, and don't change the behavior otherwise. Theintent is mainly to try to determine why we are seeing intermittentfailures in this area on some buildfarm members.Back-patch to 9.5 where some of these failures have happened.

1 parent158d615 commitb7b5a18Copy full SHA for b7b5a18

File tree

1 file changed

-0

lines changed

src/bin/pg_ctl
- pg_ctl.c

1 file changed

-0

lines changed

`‎src/bin/pg_ctl/pg_ctl.c`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -648,7 +648,12 @@ test_postmaster_connection(bool do_checkpoint)`
`648`	`648`	`structstatstatbuf;`
`649`	`649`
`650`	`650`	`if (stat(pid_file,&statbuf)!=0)`
	`651`	`+{`
	`652`	`+if (errno!=ENOENT)`
	`653`	`+write_stderr(_("\n%s: could not stat file \"%s\": %s\n"),`
	`654`	`+progname,pid_file,strerror(errno));`
`651`	`655`	`returnPQPING_NO_RESPONSE;`
	`656`	`+}`
`652`	`657`
`653`	`658`	`if (found_stale_pidfile)`
`654`	`659`	`{`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb7b5a18

File tree

1 file changed

1 file changed

`‎src/bin/pg_ctl/pg_ctl.c`

0 commit comments