NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitb67ad04

committed

Improve commentary in match_pathkeys_to_index().

For a little while there I thought match_pathkeys_to_index() was brokenbecause it wasn't trying to match index columns to pathkeys in order.Actually that's correct, because GiST can support ordering operatorson any random collection of index columns, but it sure needs a comment.

1 parentdd4134e commitb67ad04Copy full SHA for b67ad04

File tree

1 file changed

-0

lines changed

src/backend/optimizer/path
- indxpath.c

1 file changed

-0

lines changed

`‎src/backend/optimizer/path/indxpath.c`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2174,6 +2174,13 @@ match_pathkeys_to_index(IndexOptInfo index, List pathkeys,`
`2174`	`2174`	`if (!bms_equal(member->em_relids,index->rel->relids))`
`2175`	`2175`	`continue;`
`2176`	`2176`
	`2177`	`+/*`
	`2178`	`+ * We allow any column of the index to match each pathkey; they`
	`2179`	`+ * don't have to match left-to-right as you might expect. This`
	`2180`	`+ * is correct for GiST, which is the sole existing AM supporting`
	`2181`	`+ * amcanorderbyop. We might need different logic in future for`
	`2182`	`+ * other implementations.`
	`2183`	`+ */`
`2177`	`2184`	`for (indexcol=0;indexcol<index->ncolumns;indexcol++)`
`2178`	`2185`	`{`
`2179`	`2186`	`Expr*expr;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitb67ad04

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/indxpath.c`

0 commit comments