Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitb46c921

Browse files
committed
Fix assorted bugs in privileges-for-types patch.
Commit7292055 added privileges on datatypes, but there were a number of oversights. The implementation ofdefault privileges for types missed a few places, and pg_dump wasutterly innocent of the whole concept. Per bug #7741 from Nathan Alden,and subsequent wider investigation.
1 parenta99c42f commitb46c921

File tree

7 files changed

+110
-29
lines changed

7 files changed

+110
-29
lines changed

‎doc/src/sgml/catalogs.sgml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2674,7 +2674,8 @@
26742674
Type of object this entry is for:
26752675
<literal>r</> = relation (table, view),
26762676
<literal>S</> = sequence,
2677-
<literal>f</> = function
2677+
<literal>f</> = function,
2678+
<literal>T</> = type
26782679
</entry>
26792680
</row>
26802681

‎src/backend/catalog/aclchk.c‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1346,10 +1346,13 @@ RemoveRoleFromObjectACL(Oid roleid, Oid classid, Oid objid)
13461346
caseDEFACLOBJ_FUNCTION:
13471347
iacls.objtype=ACL_OBJECT_FUNCTION;
13481348
break;
1349+
caseDEFACLOBJ_TYPE:
1350+
iacls.objtype=ACL_OBJECT_TYPE;
1351+
break;
13491352
default:
13501353
/* Shouldn't get here */
1351-
elog(ERROR,"unexpected default ACL type %d",
1352-
pg_default_acl_tuple->defaclobjtype);
1354+
elog(ERROR,"unexpected default ACL type: %d",
1355+
(int)pg_default_acl_tuple->defaclobjtype);
13531356
break;
13541357
}
13551358

‎src/backend/catalog/dependency.c‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2899,6 +2899,11 @@ getObjectDescription(const ObjectAddress *object)
28992899
_("default privileges on new functions belonging to role %s"),
29002900
GetUserNameFromId(defacl->defaclrole));
29012901
break;
2902+
caseDEFACLOBJ_TYPE:
2903+
appendStringInfo(&buffer,
2904+
_("default privileges on new types belonging to role %s"),
2905+
GetUserNameFromId(defacl->defaclrole));
2906+
break;
29022907
default:
29032908
/* shouldn't get here */
29042909
appendStringInfo(&buffer,

‎src/bin/pg_dump/dumputils.c‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -890,6 +890,9 @@ do { \
890890
}
891891
elseif (strcmp(type,"TABLESPACE")==0)
892892
CONVERT_PRIV('C',"CREATE");
893+
elseif (strcmp(type,"TYPE")==0||
894+
strcmp(type,"TYPES")==0)
895+
CONVERT_PRIV('U',"USAGE");
893896
elseif (strcmp(type,"FOREIGN DATA WRAPPER")==0)
894897
CONVERT_PRIV('U',"USAGE");
895898
elseif (strcmp(type,"FOREIGN SERVER")==0)

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp