NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitaf8a94d

committed

Silence uninitialized variable compiler warning in sepgsql

At -Og optimization gcc warns that variable tclass may be useduninitialized when relkind == RELKIND_INDEX. Actually that can'thappen due to an early return, but quiet the compiler by initializingtclass to 0.In passing, use uint16_t consistently for the declaration of tclass.Complaint and initial patch by Mike Palmiotto. Editorializing by me.Probably not worth backpatching given that it is cosmetic, so applyto development head only.Discussion:https://postgr.es/m/flat/623bcaae-112e-ced0-8c22-a84f75ae0c53%40joeconway.com

1 parentbd190ea commitaf8a94dCopy full SHA for af8a94d

File tree

1 file changed

-2

lines changed

contrib/sepgsql
- relation.c

1 file changed

-2

lines changed

`‎contrib/sepgsql/relation.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ sepgsql_relation_post_create(Oid relOid)`
`243`	`243`	`HeapTupletuple;`
`244`	`244`	`Form_pg_classclassForm;`
`245`	`245`	`ObjectAddressobject;`
`246`		`-uint16tclass;`
	`246`	`+uint16_ttclass;`
`247`	`247`	`charscontext;/ subject */`
`248`	`248`	`chartcontext;/ schema */`
`249`	`249`	`charrcontext;/ relation */`
`@@ -413,7 +413,7 @@ sepgsql_relation_drop(Oid relOid)`
`413`	`413`	`{`
`414`	`414`	`ObjectAddressobject;`
`415`	`415`	`char*audit_name;`
`416`		`-uint16_ttclass;`
	`416`	`+uint16_ttclass=0;`
`417`	`417`	`charrelkind;`
`418`	`418`
`419`	`419`	`relkind=get_rel_relkind(relOid);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitaf8a94d

File tree

1 file changed

1 file changed

`‎contrib/sepgsql/relation.c`

0 commit comments