Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commitaeb5023

Browse files
author
Neil Conway
committed
Minor code cleanup: ExecHash() was returning a null TupleTableSlot, and an
old comment in the code claimed that this was necessary. Since it is notactually necessary any more, it is clearer to remove the comment andjust return NULL instead -- the return value of ExecHash() is not used.
1 parente1b398c commitaeb5023

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

‎src/backend/executor/nodeHash.c

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/executor/nodeHash.c,v 1.91 2005/03/16 21:38:07 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/executor/nodeHash.c,v 1.92 2005/03/31 02:02:52 neilc Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -54,7 +54,6 @@ ExecHash(HashState *node)
5454
* get state info from node
5555
*/
5656
outerNode=outerPlanState(node);
57-
5857
hashtable=node->hashtable;
5958

6059
/*
@@ -78,11 +77,8 @@ ExecHash(HashState *node)
7877
ExecHashTableInsert(hashtable,ExecFetchSlotTuple(slot),hashvalue);
7978
}
8079

81-
/*
82-
* Return the slot so that we have the tuple descriptor when we need
83-
* to save/restore them. -Jeff 11 July 1991 (XXX isn't this dead code?)
84-
*/
85-
returnslot;
80+
/* We needn't return a tuple slot or anything else */
81+
returnNULL;
8682
}
8783

8884
/* ----------------------------------------------------------------

‎src/backend/executor/nodeHashjoin.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*
99
*
1010
* IDENTIFICATION
11-
* $PostgreSQL: pgsql/src/backend/executor/nodeHashjoin.c,v 1.69 2005/03/16 21:38:07 tgl Exp $
11+
* $PostgreSQL: pgsql/src/backend/executor/nodeHashjoin.c,v 1.70 2005/03/31 02:02:52 neilc Exp $
1212
*
1313
*-------------------------------------------------------------------------
1414
*/
@@ -97,8 +97,7 @@ ExecHashJoin(HashJoinState *node)
9797
* outer tuple; so we can stop scanning the inner scan if we matched
9898
* on the previous try.
9999
*/
100-
if (node->js.jointype==JOIN_IN&&
101-
node->hj_MatchedOuter)
100+
if (node->js.jointype==JOIN_IN&&node->hj_MatchedOuter)
102101
node->hj_NeedNewOuter= true;
103102

104103
/*

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp