NotificationsYou must be signed in to change notification settings
Fork5
Star27

Commitadeee97

committed

Fix dumb bug in tqueue.c

When I wrote this code originally, the intention was to recompute theremapinfo only when the tupledesc changes. This presumably onlyhappens once per query, but I copied the design pattern from otherDestReceivers. However, due to a silly oversight on my part,tqueue->tupledesc never got set, leading to recomputation for everytuple.This should improve the performance of parallel scans that return asignificant number of tuples.Report by Amit Kapila; patch by me, reviewed by him.

1 parent5f10b7a commitadeee97Copy full SHA for adeee97

File tree

1 file changed

-4

lines changed

src/backend/executor
- tqueue.c

1 file changed

-4

lines changed

`‎src/backend/executor/tqueue.c‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -127,15 +127,15 @@ tqueueReceiveSlot(TupleTableSlot slot, DestReceiver self)`
`127`	`127`	`* new tupledesc. This is a strange test both because the executor really`
`128`	`128`	`* shouldn't change the tupledesc, and also because it would be unsafe if`
`129`	`129`	`* the old tupledesc could be freed and a new one allocated at the same`
`130`		`- * address. But since some very old code in printtup.c usesthis test, we`
`131`		`- * adopt it here as well.`
	`130`	`+ * address. But since some very old code in printtup.c usesa similar`
	`131`	`+ *test, weadopt it here as well.`
`132`	`132`	`*/`
`133`		`-if (tqueue->tupledesc!=tupledesc\|\|`
`134`		`-tqueue->remapinfo->natts!=tupledesc->natts)`
	`133`	`+if (tqueue->tupledesc!=tupledesc)`
`135`	`134`	`{`
`136`	`135`	`if (tqueue->remapinfo!=NULL)`
`137`	`136`	`pfree(tqueue->remapinfo);`
`138`	`137`	`tqueue->remapinfo=BuildRemapInfo(tupledesc);`
	`138`	`+tqueue->tupledesc=tupledesc;`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`tuple=ExecMaterializeSlot(slot);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitadeee97

File tree

1 file changed

1 file changed

`‎src/backend/executor/tqueue.c‎`

0 commit comments