NotificationsYou must be signed in to change notification settings
Fork5
Star26

Commitab9c433

committed

Don't build full initial logical decoding snapshot if NOEXPORT_SNAPSHOT.

Earlier commits (56e19d9 and2bef06d) make it cheaper tocreate a logical slot if not exporting the initial snapshot. IfNOEXPORT_SNAPSHOT is specified, we can skip the overhead, not justwhen creating a slot via sql (which can't export snapshots). AsNOEXPORT_SNAPSHOT has only recently been introduced, this shouldn't bebackpatched.

1 parent56e19d9 commitab9c433Copy full SHA for ab9c433

File tree

1 file changed

-2

lines changed

src/backend/replication
- walsender.c

1 file changed

-2

lines changed

`‎src/backend/replication/walsender.c`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -873,6 +873,7 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)`
`873`	`873`	`if (cmd->kind==REPLICATION_KIND_LOGICAL)`
`874`	`874`	`{`
`875`	`875`	`LogicalDecodingContext*ctx;`
	`876`	`+boolneed_full_snapshot= false;`
`876`	`877`
`877`	`878`	`/*`
`878`	`879`	`* Do options check early so that we can bail before calling the`
`@@ -884,6 +885,8 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)`
`884`	`885`	`ereport(ERROR,`
`885`	`886`	`(errmsg("CREATE_REPLICATION_SLOT ... EXPORT_SNAPSHOT "`
`886`	`887`	`"must not be called inside a transaction")));`
	`888`	`+`
	`889`	`+need_full_snapshot= true;`
`887`	`890`	`}`
`888`	`891`	`elseif (snapshot_action==CRS_USE_SNAPSHOT)`
`889`	`892`	`{`
`@@ -906,10 +909,11 @@ CreateReplicationSlot(CreateReplicationSlotCmd *cmd)`
`906`	`909`	`ereport(ERROR,`
`907`	`910`	`(errmsg("CREATE_REPLICATION_SLOT ... USE_SNAPSHOT "`
`908`	`911`	`"must not be called in a subtransaction")));`
	`912`	`+`
	`913`	`+need_full_snapshot= true;`
`909`	`914`	`}`
`910`	`915`
`911`		`-ctx=CreateInitDecodingContext(cmd->plugin,NIL,`
`912`		`-true,/* build snapshot */`
	`916`	`+ctx=CreateInitDecodingContext(cmd->plugin,NIL,need_full_snapshot,`
`913`	`917`	`logical_read_xlog_page,`
`914`	`918`	`WalSndPrepareWrite,WalSndWriteData);`
`915`	`919`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitab9c433

File tree

1 file changed

1 file changed

`‎src/backend/replication/walsender.c`

0 commit comments